Re: [PATCH 1/4] dt-bindings: clock: Add LPASS AUDIOCC and reset controller for Glymur

[Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>]

On 9/22/26 7:54 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: incorrect `#clock-cells` requirement for reset-only provider
This binding is for  clock controller which also has reset controls

Its pretty much inline with what is done with other lpass audiocc bindings.


--srini
> --
> 
> commit 347d3aed7b27ab7cf248e5a7c46279253cf08e0e
> Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> 
> dt-bindings: clock: Add LPASS AUDIOCC and reset controller for Glymur
> 
> This commit introduces device tree bindings for the LPASS audio clock and
> reset controller on Glymur. It defines the compatible string and required
> properties for the device node.
> 
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,glymur-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,glymur-lpasscc.yaml
>> new file mode 100644
>> index 0000000000000..c047c0174a93d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,glymur-lpasscc.yaml
> [ ... ]
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,glymur-lpassaudiocc
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  '#clock-cells':
>> +    const: 1
>> +
>> +  '#reset-cells':
>> +    const: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - '#clock-cells'
> 
> [Severity: Low]
> Since the commit message specifies that the audio clock controller only
> provides reset support when it is under the control of Q6DSP, and zero
> clocks are exported to Linux, should '#clock-cells' be required here?
> 
> Making '#clock-cells' a required property forces device tree authors to
> include an unused, dummy property that incorrectly models the hardware's
> capabilities just to pass DT schema validation. Similar reset-only clock
> controller bindings (e.g., qcom,sm6115-lpasscc.yaml) correctly omit the
> '#clock-cells' property entirely.
> 
>> +  - '#reset-cells'
>