Re: [PATCH v2 4/4] arm64: dts: allwinner: h6: Use RSB for AXP805 PMIC connection

Samuel Holland
2021-01-05T03:33:09Z

On 1/4/21 4:54 AM, André Przywara wrote:
> On 03/01/2021 10:00, Samuel Holland wrote:
>> On boards where the only peripheral connected to PL0/PL1 is an X-Powers
>> PMIC, configure the connection to use the RSB bus rather than the I2C
>> bus. Compared to the I2C controller that shares the pins, the RSB
>> controller allows a higher bus frequency, and it is more CPU-efficient.
>
> But is it really necessary to change the DTs for those boards in this
> way? It means those newer DTs now become incompatible with older
> kernels, and I don't know if those reasons above really justify this.
>
> I understand that we officially don't care about "newer DTs on older
> kernels", but do we really need to break this deliberately, for no
> pressing reasons?

That's a reasonable concern. I am fine if you want to delay or drop patch 4.

Cheers,
Samuel

> Cheers,
> Andre
>
> P.S. I am fine with supporting RSB on H6, and even using it on new DTs,
> just want to avoid breaking existing ones.
>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>> ---
>> .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 38 +++++++++----------
>> .../dts/allwinner/sun50i-h6-orangepi-3.dts | 14 +++----
>> .../dts/allwinner/sun50i-h6-orangepi.dtsi | 22 +++++------
>> 3 files changed, 37 insertions(+), 37 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
>> index 7c9dbde645b5..3452add30cc4 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
>> @@ -150,12 +150,28 @@ &pio {
>> vcc-pg-supply = <&reg_aldo1>;
>> };
>>
>> -&r_i2c {
>> +&r_ir {
>> + linux,rc-map-name = "rc-beelink-gs1";
>> + status = "okay";
>> +};
>> +
>> +&r_pio {
>> + /*
>> + * FIXME: We can't add that supply for now since it would
>> + * create a circular dependency between pinctrl, the regulator
>> + * and the RSB Bus.
>> + *
>> + * vcc-pl-supply = <&reg_aldo1>;
>> + */
>> + vcc-pm-supply = <&reg_aldo1>;
>> +};
>> +
>> +&r_rsb {
>> status = "okay";
>>
>> - axp805: pmic@36 {
>> + axp805: pmic@745 {
>> compatible = "x-powers,axp805", "x-powers,axp806";
>> - reg = <0x36>;
>> + reg = <0x745>;
>> interrupt-parent = <&r_intc>;
>> interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>> interrupt-controller;
>> @@ -273,22 +289,6 @@ sw {
>> };
>> };
>>
>> -&r_ir {
>> - linux,rc-map-name = "rc-beelink-gs1";
>> - status = "okay";
>> -};
>> -
>> -&r_pio {
>> - /*
>> - * PL0 and PL1 are used for PMIC I2C
>> - * don't enable the pl-supply else
>> - * it will fail at boot
>> - *
>> - * vcc-pl-supply = <&reg_aldo1>;
>> - */
>> - vcc-pm-supply = <&reg_aldo1>;
>> -};
>> -
>> &rtc {
>> clocks = <&ext_osc32k>;
>> };
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
>> index 15c9dd8c4479..16702293ac0b 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
>> @@ -175,12 +175,16 @@ &pio {
>> vcc-pg-supply = <&reg_vcc_wifi_io>;
>> };
>>
>> -&r_i2c {
>> +&r_ir {
>> + status = "okay";
>> +};
>> +
>> +&r_rsb {
>> status = "okay";
>>
>> - axp805: pmic@36 {
>> + axp805: pmic@745 {
>> compatible = "x-powers,axp805", "x-powers,axp806";
>> - reg = <0x36>;
>> + reg = <0x745>;
>> interrupt-parent = <&r_intc>;
>> interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>> interrupt-controller;
>> @@ -291,10 +295,6 @@ sw {
>> };
>> };
>>
>> -&r_ir {
>> - status = "okay";
>> -};
>> -
>> &rtc {
>> clocks = <&ext_osc32k>;
>> };
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
>> index ebc120a9232f..23e3cb2ffd8d 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
>> @@ -112,12 +112,20 @@ &pio {
>> vcc-pg-supply = <&reg_aldo1>;
>> };
>>
>> -&r_i2c {
>> +&r_ir {
>> + status = "okay";
>> +};
>> +
>> +&r_pio {
>> + vcc-pm-supply = <&reg_bldo3>;
>> +};
>> +
>> +&r_rsb {
>> status = "okay";
>>
>> - axp805: pmic@36 {
>> + axp805: pmic@745 {
>> compatible = "x-powers,axp805", "x-powers,axp806";
>> - reg = <0x36>;
>> + reg = <0x745>;
>> interrupt-parent = <&r_intc>;
>> interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>> interrupt-controller;
>> @@ -232,14 +240,6 @@ sw {
>> };
>> };
>>
>> -&r_ir {
>> - status = "okay";
>> -};
>> -
>> -&r_pio {
>> - vcc-pm-supply = <&reg_bldo3>;
>> -};
>> -
>> &rtc {
>> clocks = <&ext_osc32k>;
>> };
>>
>