From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3630C282CE for ; Wed, 24 Apr 2019 14:42:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 689C3218FD for ; Wed, 24 Apr 2019 14:42:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dQjuziyF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726935AbfDXOmD (ORCPT ); Wed, 24 Apr 2019 10:42:03 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:39012 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730876AbfDXOmC (ORCPT ); Wed, 24 Apr 2019 10:42:02 -0400 Received: by mail-lj1-f194.google.com with SMTP id l7so17143304ljg.6 for ; Wed, 24 Apr 2019 07:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:cc:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zXaOpX8Lre7VsMSZ/gZQQhrrkcGpxKH/1yAvbfjjKTE=; b=dQjuziyFIF/EM92Yx4PV65hu71AK52XYZlaTVnNRvb9eMVvQwnSRsGdnqrrAO/B59n qfEQGqK29XMrI5y1sAy2y924UjRyC4gp4TvPZxqPMmDWmsR3tGq+sXkaSZSsZtWfxd2g PbrIGrJ9Qm33OLaApPY3jI3vKN6xPE1zPSfZApozZsAkyhQaWK72df4TPn7/7Bl/NU8s kl4N4ffxVYoUS1k0bppLBA+7KPEzFnzIZLsaWpaQhrB7x93MViWBVukktQAaj5TbPIQw 5jIPkq+HCDp2YNhdUpYdTphy/WtAH85idYQJqsFrimNgogDh4HmWWCW1xD8/MCITMBGN pk/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zXaOpX8Lre7VsMSZ/gZQQhrrkcGpxKH/1yAvbfjjKTE=; b=hfGRT18XlQb8guPs42AqLdaTWyYY7lYP1poSDU7WMz19yFvQf8IJVjaf6NBdHXlS+l oGxt8fnfQulCC0NHhD/g3CkjUHWHdbTEdi+MGvKobwWMqarUDfACu9kvx9cnPphJJHVW ruUZteJKCjklEOHVdQQA1GbSjjBkKrx48WPAJ/4LNnclfLHSg9XkOVfbj8jgL0vUcq7V 6SsaaKghbXzkYxWWlWnnBTXatYAg6EGyuFbSEoDEujV1I64II+VR0oEJNJ/UkgKcjhax zdzQYgJ51JxPAhAbc4UvveCcQLXiAzs9wVSFt+KyATk8U7eLcFpR9Wzfa2+dBObphyUm eeLg== X-Gm-Message-State: APjAAAUUUrNBGjHl/YxUGeWTXvZnAmyFdMg/61U1oy5KaxEfUQTlL1xw OilPSZiwmFRq0buBv+rhvAiO5wUr X-Google-Smtp-Source: APXvYqzQPaLXdURKW1Pzjpg2iDTMRCV+AitI17ROKiocBP/HeGjERtnMMthL46nb6UAIhgtNV8c9Zw== X-Received: by 2002:a2e:7f13:: with SMTP id a19mr17403867ljd.35.1556116920222; Wed, 24 Apr 2019 07:42:00 -0700 (PDT) Received: from [192.168.2.145] (ppp94-29-35-107.pppoe.spdop.ru. [94.29.35.107]) by smtp.googlemail.com with ESMTPSA id y7sm3986386ljj.34.2019.04.24.07.41.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 07:41:59 -0700 (PDT) Subject: Re: [chanwoo:devfreq-testing 15/16] drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'? To: Chanwoo Choi References: <201904242234.3ZpDzMBq%lkp@intel.com> From: Dmitry Osipenko Cc: linux-clk@vger.kernel.org Message-ID: Date: Wed, 24 Apr 2019 17:41:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <201904242234.3ZpDzMBq%lkp@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 24.04.2019 17:22, kbuild test robot пишет: > Hi Dmitry, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-testing > head: 6b3a07e6458befbb8b90010e92d578b08678e5ce > commit: d2a110d18c755979bffa07f45d3b4ff89e420954 [15/16] PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c > config: sparc64-allmodconfig (attached as .config) > compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout d2a110d18c755979bffa07f45d3b4ff89e420954 > # save the attached .config to linux build tree > GCC_VERSION=7.2.0 make.cross ARCH=sparc64 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > All errors (new ones prefixed by >>): > > drivers//devfreq/tegra30-devfreq.c: In function 'tegra_devfreq_target': >>> drivers//devfreq/tegra30-devfreq.c:478:8: error: implicit declaration of function 'clk_set_min_rate'; did you mean 'clk_set_rate'? [-Werror=implicit-function-declaration] > err = clk_set_min_rate(tegra->emc_clock, rate); > ^~~~~~~~~~~~~~~~ > clk_set_rate > cc1: some warnings being treated as errors > > vim +478 drivers//devfreq/tegra30-devfreq.c > > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 460 > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 461 static int tegra_devfreq_target(struct device *dev, unsigned long *freq, > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 462 u32 flags) > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 463 { > 11573e913 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2015-03-17 464 struct tegra_devfreq *tegra = dev_get_drvdata(dev); > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 465 struct devfreq *devfreq = tegra->devfreq; > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 466 struct dev_pm_opp *opp; > e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 467 unsigned long rate; > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 468 int err; > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 469 > e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 470 opp = devfreq_recommended_opp(dev, freq, flags); > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 471 if (IS_ERR(opp)) { > e76bb6df1 drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 472 dev_err(dev, "Failed to find opp for %lu Hz\n", *freq); > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 473 return PTR_ERR(opp); > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 474 } > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 475 rate = dev_pm_opp_get_freq(opp); > 8a31d9d94 drivers/devfreq/tegra-devfreq.c Viresh Kumar 2017-01-23 476 dev_pm_opp_put(opp); > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 477 > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 @478 err = clk_set_min_rate(tegra->emc_clock, rate); > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 479 if (err) > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 480 return err; > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 481 > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 482 err = clk_set_rate(tegra->emc_clock, 0); > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 483 if (err) > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 484 goto restore_min_rate; > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 485 > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 486 return 0; > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 487 > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 488 restore_min_rate: > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 489 clk_set_min_rate(tegra->emc_clock, devfreq->previous_freq); > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 490 > 7f2e3eb6f drivers/devfreq/tegra-devfreq.c Dmitry Osipenko 2019-04-18 491 return err; > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 492 } > 6234f3801 drivers/devfreq/tegra-devfreq.c Tomeu Vizoso 2014-11-24 493 > > :::::: The code at line 478 was first introduced by commit > :::::: 7f2e3eb6fa764bb003164c331c93306a8e1223c3 PM / devfreq: tegra: Don't ignore clk errors > > :::::: TO: Dmitry Osipenko > :::::: CC: Chanwoo Choi > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > Oh, there is no declaration for clk_set_min_rate() when CONFIG_COMMON_CLK=n. Either driver should be made dependent on CONFIG_COMMON_CLK or the declaration should be added to include/linux/clk.h (the same applies to tegra20-devfreq). Chanwoo, what will we do?