From: Markus Elfring <Markus.Elfring@web.de>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
linux-clk@vger.kernel.org, Brian Masney <bmasney@redhat.com>,
Gabriel Fernandez <gabriel.fernandez@st.com>,
Michael Turquette <mturquette@baylibre.com>,
Pankaj Dev <pankaj.dev@st.com>, Stephen Boyd <sboyd@kernel.org>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register()
Date: Thu, 15 Jan 2026 14:03:34 +0100 [thread overview]
Message-ID: <bf800455-6f93-4695-a36d-e6bfcb9a7e34@web.de> (raw)
In-Reply-To: <20260115045524.640427-1-lihaoxiang@isrc.iscas.ac.cn>
> If clk_register_composite() fails, call kfree() to release
> div and gate.
You may put such information also into a single text line.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n659
How do you think about to avoid a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc5#n526
Regards,
Markus
prev parent reply other threads:[~2026-01-15 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 4:55 [PATCH] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register() Haoxiang Li
2026-01-15 12:01 ` Brian Masney
2026-01-15 13:03 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf800455-6f93-4695-a36d-e6bfcb9a7e34@web.de \
--to=markus.elfring@web.de \
--cc=bmasney@redhat.com \
--cc=gabriel.fernandez@st.com \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=mturquette@linaro.org \
--cc=pankaj.dev@st.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox