From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB5FC43219 for ; Tue, 22 Nov 2022 08:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232681AbiKVIFS (ORCPT ); Tue, 22 Nov 2022 03:05:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232647AbiKVIFJ (ORCPT ); Tue, 22 Nov 2022 03:05:09 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 545D7391F4; Tue, 22 Nov 2022 00:05:07 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 9872324E238; Tue, 22 Nov 2022 16:05:00 +0800 (CST) Received: from EXMBX072.cuchost.com (172.16.6.82) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 22 Nov 2022 16:05:00 +0800 Received: from [192.168.125.106] (113.72.144.23) by EXMBX072.cuchost.com (172.16.6.82) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 22 Nov 2022 16:04:59 +0800 Message-ID: Date: Tue, 22 Nov 2022 16:04:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 07/14] dt-bindings: clock: Add StarFive JH7110 system and always-on clock definitions Content-Language: en-US To: Krzysztof Kozlowski , , , CC: Conor Dooley , Palmer Dabbelt , "Rob Herring" , Krzysztof Kozlowski , Stephen Boyd , "Michael Turquette" , Philipp Zabel , Emil Renner Berthing , References: <20221118010627.70576-1-hal.feng@starfivetech.com> <20221118010627.70576-8-hal.feng@starfivetech.com> <4d1fbddc-ee8b-1ab3-d1a9-8496bda3f668@linaro.org> <1db979d5-1fb6-f3c9-8ce0-e3e2e23e5d14@starfivetech.com> From: Hal Feng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.23] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX072.cuchost.com (172.16.6.82) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, 22 Nov 2022 08:41:26 +0100, Krzysztof Kozlowski wrote: > On 22/11/2022 02:02, Hal Feng wrote: >> On Mon, 21 Nov 2022 09:45:11 +0100, Krzysztof Kozlowski wrote: >>> On 18/11/2022 02:06, Hal Feng wrote: >>>> From: Emil Renner Berthing >>>> >>>> Add all clock outputs for the StarFive JH7110 system (SYS) and >>>> always-on (AON) clock generator. >>>> >>>> Signed-off-by: Emil Renner Berthing >>>> Signed-off-by: Hal Feng >>>> --- >>>> MAINTAINERS | 5 +- >>>> include/dt-bindings/clock/starfive-jh7110.h | 234 ++++++++++++++++++++ >>>> 2 files changed, 237 insertions(+), 2 deletions(-) >>>> create mode 100644 include/dt-bindings/clock/starfive-jh7110.h >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index e6f1060e7964..e97dac9c0ee4 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -19598,12 +19598,13 @@ M: Ion Badulescu >>>> S: Odd Fixes >>>> F: drivers/net/ethernet/adaptec/starfire* >>>> >>>> -STARFIVE JH7100 CLOCK DRIVERS >>>> +STARFIVE CLOCK DRIVERS >>>> M: Emil Renner Berthing >>>> +M: Hal Feng >>>> S: Maintained >>>> F: Documentation/devicetree/bindings/clock/starfive,jh7100-*.yaml >>>> F: drivers/clk/starfive/ >>>> -F: include/dt-bindings/clock/starfive-jh7100*.h >>>> +F: include/dt-bindings/clock/starfive* >>>> >>>> STARFIVE JH7100 PINCTRL DRIVER >>>> M: Emil Renner Berthing >>>> diff --git a/include/dt-bindings/clock/starfive-jh7110.h b/include/dt-bindings/clock/starfive-jh7110.h >>> >>> Filename based / the same as compatible (or bindings filename). >> >> Should I split this file into two files for "SYSCRG" and "AONCRG", which >> maybe named as "starfive-jh7110-sys.h" and "starfive-jh7110-aon.h". Ditto >> for the patch 8. > > Does not have to be, but anyway naming must follow compatible naming, so > vendor,soc-device. Can I name it "starfive,jh7110-crg.h"? This file is included in starfive,jh7110-syscrg.yaml and starfive,jh7110-aoncrg.yaml. Best regards, Hal