From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4640B329C40 for ; Thu, 10 Sep 2026 09:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789031337; cv=none; b=HDpRQ2jEOc3fZ+Di7avvCvwQZwbRL3fWkZ9a8JbZgngnfjCMj+wqncTJKul/O2YlWnrKeo4Vcmdo0+0Ysfnssmc/3wd4UWLz+VmS5kPTZbr7HUcn6IShyg8cAic7yAKMjPdYnmmF0/Jx83wM+onk/KbRGlIPrEX9bIm0vv+ZZyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789031337; c=relaxed/simple; bh=8hucToE/S2WnPZso0gnJA+O2VAR3ifQB1yaddh/RmOo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RuaowwkvHysUK8+nPuwAY1eTNz5sCwIpBp0I1p7lyzoZAExJUiQPt2/pHdEbYq6DW+pO5XrMlgnSI2xJNqZz+jnhlDyfhHKpLTaImJ9Vu6sUQaI7LL7zBqzBvawyp2TjMt8Q3nc9RfIR88SrzB6165W9+4SxWqSSfNlYaxpOIU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fol/YjlM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WxgYE1/1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fol/YjlM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WxgYE1/1" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68A8pwv9341364 for ; Thu, 10 Sep 2026 09:08:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d2oHrCYelfY902R11wYb1NIL+eyiOUVA471Ms03DAnU=; b=fol/YjlMaFcZwH68 /QxXyBXIj+Kpq+O8BRI4IayJmCyzzZ9VyqBwym64divFMmU5BJ4nFVl2d28qKyk6 mZfkxPo/uwHKaN5ccCCLMl5rO62bp4+F7ODn64CmT3Rd2Bm2E+YFwVwy7MhXf1wi l/KlLzv9ykFoV03GHLJHxnLj58En3q4GdNS85qaKy7A8HPuIcS/cgRWjDU4JY6Ow vvvevd9SQxkRn9r7C4UChRh4JinSZCywSHJqwS5hJ8OZz7I9mpzFP0OYISE5l64X nL5K1hqOqLd3f4mRO09yFXW6yJzFYSsEVnHY9ocmUdv4JjabQLYzPOMFqEWQq2KZ CHFiVw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gkrak8bbv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 10 Sep 2026 09:08:53 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-381250979d5so8522909a91.0 for ; Thu, 10 Sep 2026 02:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789031333; x=1789636133; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=d2oHrCYelfY902R11wYb1NIL+eyiOUVA471Ms03DAnU=; b=WxgYE1/1wcQ5xODfGKFTMZbhMSVrZpq/I6AoFB9cIBtQ6aU/54X9RC0Bt3xUDRPI6K SHpwSeDoUjD7lE6DywgBLisxpGDNcG4VspcutERqLBe1RMzjLyFPmVqhX660cMbKXm4/ KGps6W0onpZtKidN61FSFYJVfNZD3S321uNsq6dHRVh7K7pllQkebQiui9Ap92xc7A7t thFkeqTHN9M/8g8kX0O/jIg6AXbEY7aNM1FVvJd1+TBD0y0sUJVhJ8v4jQ6p0saBYwwa OvfRnm00IR+AiVC06/qF/4i6rShnGTz+/fBUSxNI50OuSeYZAikNCiK1aAeX5Fd06XzF SdSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789031333; x=1789636133; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d2oHrCYelfY902R11wYb1NIL+eyiOUVA471Ms03DAnU=; b=OsBZ0btMiXpRwOnHMTKH8bsZP8ik6PVWzCbttJGlFH+K1dyMfeD0Eb4WihoqKzeuRp S4amCKIH7qj7jLbfsQZhDqIIoQYRVKtKbedaoRx6eNa9I0og9SJgZkoDvX40HvOGsumt 0pGcP5EJWKb/MRiiSvaHIgtkTgCvKOKXOVtmLQqKPe/ukq23pn3JXGVprl40t5g81pZu Ya14cUEoX78eynXcFCAhWN5JW09QpoChLAVkaA3fwsO2dzAcL0l9tm9eavsHmqdcBrai P8diOilRrNxhxsXk1ZX2BauKd5/bkRO6BTgC5oDTudfK96xupfRBholqAh6yKMBjzapA S7RA== X-Forwarded-Encrypted: i=1; AKwUvBwfB3NXN/tn9d4yyEn9XrelXcdG90dH9ThAFW814TmfA5gX2KJRgLEZULFXbcc1Rdy72Vf1f/CMpn4=@vger.kernel.org X-Gm-Message-State: AFuF++lhHdsgHJM9HMmtQ6BMdSBndC9z4RaCtHZlaZOItX9npNgj9F0h cjhfR5ziHATFHYOuSIbTN4W0hmyCxOapWFfjL3O0SS1NGoHapj6cvFekws4C9AoYHd1pj0LUtQ2 8Ml9GxEPUKVvT/xxP1Fl91nwYzXB9O0gVDOLR4Gx3v96/XPquwTHiygn6wRWkp+E= X-Gm-Gg: AYBFou16O+IxgDcaS+Ij2f446bgG5QGZVFH4mhHyoEgNcdlkWiDNEBxT3eQMqKhdADz QYEuffMhhuh1gl9SXwTMQCDLqnHT50McuOgbZjg13ROWx12IfnhkOI06qihVANKOlfFl3oa2xaD uNXiJaZRRyt1XGswcex7AfbeBHEEO1+ne+kDIVPPs84tOgrOx5gPqKSnqPu4JNCPIMTNwZ6pLN5 RKd5b+vygljMdVqb8b+zzDnj6z3Vb0UOOjzAMXHs8HzYcu/O10564wf2NfWfT1p1ODBlJhcHuS5 eRXvq5XgwXYelmazKIvPHKdcY1I/U4NnEI1wSzw40jyFkQrkcmcUMUdXhGb4rk8hqKsZ+JMRg3S R2uwwl9sxtgmp3y4enaRPTefb8nw= X-Received: by 2002:a17:90b:1a88:b0:38f:efed:5448 with SMTP id 98e67ed59e1d1-39b2619138bmr57669045a91.8.1789031332819; Thu, 10 Sep 2026 02:08:52 -0700 (PDT) X-Received: by 2002:a17:90b:1a88:b0:38f:efed:5448 with SMTP id 98e67ed59e1d1-39b2619138bmr57668977a91.8.1789031332372; Thu, 10 Sep 2026 02:08:52 -0700 (PDT) Received: from [10.217.217.79] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33825669695sm26847186eec.3.2026.09.10.02.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2026 02:08:51 -0700 (PDT) Message-ID: Date: Thu, 10 Sep 2026 14:38:46 +0530 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] clk: qcom: dprxcc: Add Nord DPRX clock controller support To: Shawn Guo Cc: Bjorn Andersson , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260907-nords_dprx-v1-0-d472af3f01b1@oss.qualcomm.com> <20260907-nords_dprx-v1-3-d472af3f01b1@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEwMiBTYWx0ZWRfXwBfDW7Skz/pG vvdkNEhSjt5oKQPCOU1TP2U8AAQ3V2QtuJ5Q35ZM+D4M+GFM5SdHNVBczskKnKMRZidVY8j/P6X 4DagLudox0G50rawupYchVUMpExk2MY= X-Proofpoint-GUID: M3z2MvcVt1XVhgMUyXqpXwhroHmBIPQH X-Proofpoint-ORIG-GUID: M3z2MvcVt1XVhgMUyXqpXwhroHmBIPQH X-Authority-Analysis: v=2.4 cv=EspHPicA c=1 sm=1 tr=0 ts=6aa273a5 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=DBr2NRcRzsiujjGSwJMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEwMiBTYWx0ZWRfX1F6XGEyjquw4 K6KV1hjARvMw0ERko9kQiVkvIq/gMuLyGpwzTAm2F821+9Eh07co+7lMvvfRXbJfMQzZd51Pbyo 1etA4iLKUKcX47gxJfnpg9wwiBXmc1e/zDrPwJDhvRRUyPJzrLDKZ8ECBG7f250UvQAkvjPjgsD Wdq9y9/2bFVederp8bgyLa0CKN/JhqVw1NPO90pdT8L00vT+NYKhOtSbhtNSvlf3LsNNEsnVfCS 648hbJPlFBcLht2QnXT168DY3MFvDqou/vexZCKZNsy2O2q3fTDYdNgPoYX7yqjeGgvc8mIH6Kn WJdK52GWmOYOlCSPL0JDndnUHtmbTRrQFRQM7XfqwIA6N80CPg8gWZzudapZiXKQsY1BssF+GoY am/Ae3ePqkQZzDK4KVt89a7BTGxxfn+KFhnOI6UdtrxjDwQDHFyKvJf6m9giYP9xy/x1H+mnr9H MM77ePq9nsu5Hfq8EWA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100102 On 9/9/2026 2:36 PM, Shawn Guo wrote: >> --- /dev/null >> +++ b/drivers/clk/qcom/dprxcc0-nord.c >> @@ -0,0 +1,436 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#include >> +#include >> +#include > This include can be dropped. > Okay. >> +#include >> +#include >> + >> +#include >> + >> +#include "clk-alpha-pll.h" >> +#include "clk-branch.h" >> +#include "clk-pll.h" > This include doesn't seem to be needed. > >> +#include "clk-rcg.h" >> +#include "clk-regmap.h" >> +#include "clk-regmap-divider.h" >> +#include "clk-regmap-mux.h" > Ditto > Actually our generators are common across clock controllers, so they add all get added as our templates. I will remove for now. >> +#include "common.h" >> +#include "reset.h" >> + >> +enum { >> + DT_BI_TCXO, >> + DT_AHB_CLK, > The binding requires the DPRX CFG AHB clock in clocks. > > - description: DPRX CFG AHB clock from NWGCC This change ensures that NWGCC is probed before DPRX, allowing the critical NW_GCC_DPRX0/1_CFG_AHB_CLK clocks to remain enabled during the DPRX probe. > > But nothing in the driver references index 1 — not in any parent_data, > not via devm_clk_get_enabled(). -- Thanks, Taniya Das