Re: [PATCH v2 07/20] dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible

Peter Griffin
2023-10-12T11:24:27Z

Hi Sam,

Thanks for the review.

On Thu, 12 Oct 2023 at 00:12, Sam Protsenko <semen.protsenko@linaro.org> wrote:
>
> On Tue, Oct 10, 2023 at 5:49 PM Peter Griffin <peter.griffin@linaro.org> wrote:
> >
> > gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9
> > where more than one pin controller can do external wake-up interrupt.
> > So add a dedicated compatible for it.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> > .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > index 1de91a51234d..7cddce761c46 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
> > @@ -29,6 +29,7 @@ description: |
> > properties:
> > compatible:
> > enum:
> > + - google,gs101-wakeup-eint
> > - samsung,s3c2410-wakeup-eint
> > - samsung,s3c2412-wakeup-eint
> > - samsung,s3c64xx-wakeup-eint
> > @@ -99,6 +100,7 @@ allOf:
> > enum:
> > - samsung,exynos850-wakeup-eint
> > - samsung,exynosautov9-wakeup-eint
> > + - google,gs101-wakeup-eint
>
> Maybe move it on top, to keep the list sorted alphabetically?

Will fix in v4