From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Stephan Gerhold" <stephan@gerhold.net>,
"Otto Pflüger" <otto.pflueger@abscue.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Lee Jones" <lee@kernel.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Clark" <robdclark@gmail.com>, "Sean Paul" <sean@poorly.run>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dmitry Baryshkov" <lumag@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, iommu@lists.linux.dev,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org
Subject: Re: [PATCH v4 6/6] arm64: dts: qcom: Add Xiaomi Redmi 3S
Date: Mon, 14 Apr 2025 22:45:01 +0200 [thread overview]
Message-ID: <c1672544-eb0f-474d-a975-2a4f6b29d549@oss.qualcomm.com> (raw)
In-Reply-To: <20250315-msm8937-v4-6-1f132e870a49@mainlining.org>
On 3/15/25 3:57 PM, Barnabás Czémán wrote:
> Add initial support for Xiaomi Redmi 3S (land).
>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
[...]
> + headphones_switch: audio-switch {
> + compatible = "simple-audio-amplifier";
> + enable-gpios = <&tlmm 129 GPIO_ACTIVE_HIGH>;
> + sound-name-prefix = "Headphones Switch";
> + pinctrl-0 = <&headphones_switch_default>;
> + pinctrl-names = "default";
> + };
We've had a similar change lately
https://lore.kernel.org/linux-arm-msm/20250327100633.11530-1-srinivas.kandagatla@linaro.org/
I think this could be some sort of a drivers/mux/...
[...]
> +&pm8937_resin {
> + linux,code = <KEY_VOLUMEDOWN>;
> + status = "okay";
> +};
Please also unify the style such that there's a newline before status
Looks good otherwise
Konrad
prev parent reply other threads:[~2025-04-14 20:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 14:57 [PATCH v4 0/6] Initial support of MSM8937 and Xiaomi Redmi 3S Barnabás Czémán
2025-03-15 14:57 ` [PATCH v4 1/6] dt-bindings: clock: qcom: Add MSM8937 Global Clock Controller Barnabás Czémán
2025-03-17 9:17 ` Krzysztof Kozlowski
2025-03-17 9:57 ` Barnabás Czémán
2025-03-17 15:10 ` Krzysztof Kozlowski
2025-03-15 14:57 ` [PATCH v4 2/6] clk: qcom: gcc: Add support for Global Clock controller found on MSM8937 Barnabás Czémán
2025-04-14 20:35 ` Konrad Dybcio
2025-03-15 14:57 ` [PATCH v4 3/6] dt-bindings: drm/msm/gpu: Document AON clock for A505/A506/A510 Barnabás Czémán
2025-03-17 9:21 ` Krzysztof Kozlowski
2025-03-17 9:48 ` Barnabás Czémán
2025-03-17 15:18 ` Krzysztof Kozlowski
2025-03-15 14:57 ` [PATCH v4 4/6] arm64: dts: qcom: Add initial support for MSM8937 Barnabás Czémán
2025-04-14 20:55 ` Konrad Dybcio
2025-04-16 20:33 ` barnabas.czeman
2025-04-16 20:39 ` Konrad Dybcio
2025-04-17 6:20 ` barnabas.czeman
2025-04-17 11:11 ` Konrad Dybcio
2025-03-15 14:57 ` [PATCH v4 5/6] dt-bindings: arm: qcom: Add Xiaomi Redmi 3S Barnabás Czémán
2025-03-15 14:57 ` [PATCH v4 6/6] arm64: dts: " Barnabás Czémán
2025-04-14 20:45 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1672544-eb0f-474d-a975-2a4f6b29d549@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=otto.pflueger@abscue.de \
--cc=phone-devel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
--cc=tzimmermann@suse.de \
--cc=will@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox