From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C5A388898 for ; Thu, 3 Sep 2026 05:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411764; cv=none; b=ZYh4VhSr5ULF9rHXXdv7xElzVist/0pHKdvQtBbi3pPI0+PJWozCAASpm1JuRJOLiDT5+xT1WfrBfQV7Fx1vGC+h4W2o6mRM0VlWPqDcCyxwiXMB9U1Ff5syYNtvoC6kXupfceeHl7teqt3MauyOtg8U3O5huA3ksExvp2SoGOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788411764; c=relaxed/simple; bh=j8QMTNW8XDHV+BH8mGTNiSJbNMOrQ1E2SamlbJ3guog=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RqijMbP8sieiBS5dK3nqQOCjA/ldv43ttSDMvG7RE/z6FJic2TFdulR6s3bgjapmsUhLzEIvteStAPT1snqEPjVeFUzkh2n7iVMAB1HtZENkzaq61NCzRMoAM3qfV0hvevaP9k4hoVOn48MQn7zIjPNTWEvaD4OTgOWTiFpWxdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hS9TovMd; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hS9TovMd" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5b4b037a2c1so1778905e87.2 for ; Wed, 02 Sep 2026 22:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788411760; x=1789016560; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LwFiTvSfOdYmNglr5FoVqN597kWfjGSwy7pj4LDNId8=; b=hS9TovMd5QZKIZNyOpwAJtQ57wR6xsF0NLxpWkjJu4Exxer+y0BAmxudl2pCbJZXB0 s8wHmZdgs62nqz5HLUL8CikyKRTmtWfxKYvHQpbvhMT4M9eLIt+xPStnUfjqImeyY8SJ 6BfRq71N/EKv1qxb6BGEorOvJAVGsuoE20AcBf1vmIhTfDld8Du7XIA/k2Qfr/1v6CQ7 fcg2ew6rq46UtaOg5tCt/aKdd75BMIzPLjM6FrbuTgenT7XvaTGqCYcjuul229whmLRU sjs8OSK2lBQzCpQLt7bziAF2kArm6eWxxTC+Rt+UXE/DgVU0c1XWAQcTmJi4ONiTSP/P tUMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788411760; x=1789016560; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LwFiTvSfOdYmNglr5FoVqN597kWfjGSwy7pj4LDNId8=; b=Fxfpb6klJSHAKJvEloNqoCtOAtOPnUoXjy8M4sMiCQen3Kf08u1in6HTxgOA+ycabk qWAWm//TN390jQxAn/oDnkPIP5S++bCvOSRWWrR5yhU3vH2XzZNbxOkMQtVc1GwQ0FOA LSIU4AbbIhfUmLIo+ceAX6qJdK9vqWuo/pJjolmTkQqNykwL2m0UH2up/30Hmem9fj4i QRi/0kmHN4aaY4tqd0DXUl8Cjiqzd/PBRG+3LAAgoDbM1uAPl/oypzWCDREUfH6xIgzy iR8rbTDSm58y7/xemnWd+ILCNlED6VCuKhVfw6nRM3cIhZtKAvgTCchgH/T3PRfBIVzJ ZpNQ== X-Forwarded-Encrypted: i=1; AKwUvBzme8xgeokYJsfsJ75iABRxScu4hchfBkPqjUBrXrJ6H1VrpLWjfbh2BE8kUew1rcoEqbgHBEWV+cs=@vger.kernel.org X-Gm-Message-State: AFuF++mzt7zOLZHfa3rs3V1UPRYfQrWNKlKIlQHShq0U8kCTboeBbsru jjpqgM9JL/R82fjYOs7ie1tK4zwENAwg28vlvM01RDbW8+6nU52FPQ3n X-Gm-Gg: AYBFou2L9s9zRG/ij6IGmbRW7ZnNAd1o3r/zBOaUdNyUoWNd6XoQ+2JILh95lTWdMa1 T4nN5cuLFJ2h2aBZ/tViIzww8gLSZ/AIs7uJ4QC86pst3JuyKdIIzJBBbw1jIzKKWZHJROrIDgN tKeyZcYnoGO18/0NdsfEuTNawSAad9uPv4l+7Ex0wofCx0wQbkk/+I/1bnmy8NKpRHVEvoy8E+i WBdwvXIZpw29MLw3bf71t+TcCrleEBQr9WUdR0B6HPUK9FkIO1zNVFG+9CG6Q838IMwTW2EukoF aI4oxRe4wnsPMmLNoWjDuCXmmKHwCimmnb+fBjRdwaO9UCmQ8a0JmuwhlkXocTVYqeWHqfWu3w+ IRrTIeJG9XaBBGJYfzQ7Ct6g1tUUijxqgkWtJB7qehs+wBOZF8FPO7zx+V9awgKQslN85SHzwr8 QEFLJLXWKVNDOqJDHUXvOR+uVCWn2IDkIs/WJM4Ej4ROZiV04rtzpQDwbKbOVwpeifWNNYBu/vs RWrCmHzPNNAOnVlvzZnkmvAALZvWJcPwZJi3G5LBBYM X-Received: by 2002:a05:6512:110d:b0:5b5:fae5:b241 with SMTP id 2adb3069b0e04-5b608559ac7mr3146149e87.14.1788411760490; Wed, 02 Sep 2026 22:02:40 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b606b1cd21sm1021897e87.29.2026.09.02.22.02.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2026 22:02:39 -0700 (PDT) Message-ID: Date: Thu, 3 Sep 2026 08:02:39 +0300 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/10] gpio: bd73800: Support ROHM BD73800 PMIC GPIOs To: Linus Walleij Cc: Matti Vaittinen , Matti Vaittinen , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Stephen Boyd , Brian Masney , Jerome Brunet , Bartosz Golaszewski , Alexandre Belloni , Michael Walle , mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <5eb294e68b8d5d2c1d3a12b14a55dd2a9c075a09.1788346553.git.mazziesaccount@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 02/09/2026 15:39, Linus Walleij wrote: > Hi Matti, > > thanks for your patch! > > On Wed, Sep 2, 2026 at 1:07 PM Matti Vaittinen > wrote: > >> From: Matti Vaittinen >> >> The ROHM BD73800 PMIC has 4 pins (named GPIO1, CLKOUT, FAULT_B and >> EXTEN_OUT) which might have been set to operate as a GPI or GPO when OTP >> (One Time Programmable memory) is written at device manufacturing. >> Support the GPI/GPO use-case via GPIO framework. >> >> The default OTP for these pins is to not use any of them as GPI or GPO. >> (The GPIO1 defaults as an ADC input regardless the naming). Hence the >> driver assumes none of these pins is a GPI/GPO unless explicitly pointed >> as GPI or GPO via device tree. >> >> Furthermore, pin's direction can't be changed after OTP configuration is >> done. Also the default drive type for a GPO (CMOS / Open Drain) is set >> by the OTP configuration. The BD73800 has a set of undocumented test >> registers which should allow changing the drive type. Access to the test >> register area or the test registers aren't documented and so this driver >> does not support configuring the drive type even though it might be >> doable. >> >> Signed-off-by: Matti Vaittinen > > Pretty neat with gpio-regmap isn't it? :) Yep. I like the added flexibility now that it has got those callbacks a driver can register... ;) > Reviewed-by: Linus Walleij Thanks! Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~