From: <Claudiu.Beznea@microchip.com>
To: <herve.codina@bootlin.com>, <gregkh@linuxfoundation.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<Horatiu.Vultur@microchip.com>
Cc: <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 1/3] clk: lan966x: Fix the lan966x clock gate register address
Date: Tue, 5 Jul 2022 08:51:46 +0000 [thread overview]
Message-ID: <c33e0cc5-54f7-9052-efb6-36a9d7169bd4@microchip.com> (raw)
In-Reply-To: <20220704102845.168438-2-herve.codina@bootlin.com>
On 04.07.2022 13:28, Herve Codina wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The register address used for the clock gate register is the base
> register address coming from first reg map (ie. the generic
> clock registers) instead of the second reg map defining the clock
> gate register.
>
> Use the correct clock gate register address.
>
> Fixes: 5ad5915dea00 ("clk: lan966x: Extend lan966x clock driver for clock gating support")
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/clk/clk-lan966x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-lan966x.c b/drivers/clk/clk-lan966x.c
> index d1535ac13e89..81cb90955d68 100644
> --- a/drivers/clk/clk-lan966x.c
> +++ b/drivers/clk/clk-lan966x.c
> @@ -213,7 +213,7 @@ static int lan966x_gate_clk_register(struct device *dev,
>
> hw_data->hws[i] =
> devm_clk_hw_register_gate(dev, clk_gate_desc[idx].name,
> - "lan966x", 0, base,
> + "lan966x", 0, gate_base,
> clk_gate_desc[idx].bit_idx,
> 0, &clk_gate_lock);
>
> --
> 2.35.3
>
next prev parent reply other threads:[~2022-07-05 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 10:28 [PATCH v5 0/3] Microchip LAN966x USB device support Herve Codina
2022-07-04 10:28 ` [PATCH v5 1/3] clk: lan966x: Fix the lan966x clock gate register address Herve Codina
2022-07-05 8:51 ` Claudiu.Beznea [this message]
2022-07-05 13:00 ` Michael Walle
2022-07-19 7:04 ` Stephen Boyd
2022-07-04 10:28 ` [PATCH v5 2/3] dt-bindings: usb: atmel: Add Microchip LAN9662 compatible string Herve Codina
2022-07-05 7:48 ` Claudiu.Beznea
2022-07-04 10:28 ` [PATCH v5 3/3] ARM: dts: lan966x: Add UDPHS support Herve Codina
2022-07-05 7:48 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c33e0cc5-54f7-9052-efb6-36a9d7169bd4@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox