From: Krzysztof Kozlowski <krzk@kernel.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-clk@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH v2 2/4] arm64: dts: agilex5: add gmac nodes
Date: Mon, 2 Dec 2024 10:32:01 +0100 [thread overview]
Message-ID: <c3c5155b-fd0e-4790-bbd5-3874077e8159@kernel.org> (raw)
In-Reply-To: <87o71u8odo.fsf@pengutronix.de>
On 02/12/2024 09:45, Steffen Trumtrar wrote:
>>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
>>> index b1debf0317d0576f7b00200e9593481671183faa..647ccd0b5a66b68fab745d443b975c12d6ce63df 100644
>>> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
>>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
>>> @@ -141,6 +141,93 @@ soc: soc@0 {
>>> device_type = "soc";
>>> interrupt-parent = <&intc>;
>>>
>>> + gmac0: ethernet@10810000 {
>>> + compatible = "altr,socfpga-stmmac-a10-s10",
>>
>>
>> That's odd compatible, this is not Arria10 SoC, neither Stratix 10.
>
> Yes, it is. The socfpga-dwmac.txt says "Arria10/Agilex/Stratix10 SoCs" should use "altr,socfpga-stmmac-a10-s10".
>
> So, how to proceed? Adding a "altr,socfpga-stmmac-agilex5" to the binding doc and driver?
> And converting the txt to yaml, because touched it last?
You need dedicated front compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-02 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 10:33 [PATCH v2 0/4] ARM64: dts: intel: agilex5: add nodes and new board Steffen Trumtrar
2024-11-25 10:33 ` [PATCH v2 1/4] arm64: dts: agilex5: add gpio0 Steffen Trumtrar
2024-11-25 10:50 ` Krzysztof Kozlowski
2024-11-25 10:33 ` [PATCH v2 2/4] arm64: dts: agilex5: add gmac nodes Steffen Trumtrar
2024-11-25 10:51 ` Krzysztof Kozlowski
2024-12-02 8:45 ` Steffen Trumtrar
2024-12-02 9:32 ` Krzysztof Kozlowski [this message]
2024-11-25 10:33 ` [PATCH v2 3/4] dt-bindings: intel: add agilex5-based Arrow AXE5-Eagle Steffen Trumtrar
2024-11-25 10:33 ` [PATCH v2 4/4] arm64: dts: agilex5: initial support for " Steffen Trumtrar
2024-11-25 10:51 ` Krzysztof Kozlowski
2024-11-25 18:16 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3c5155b-fd0e-4790-bbd5-3874077e8159@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox