From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E27C433F5 for ; Tue, 19 Apr 2022 10:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350805AbiDSKvs (ORCPT ); Tue, 19 Apr 2022 06:51:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350826AbiDSKvp (ORCPT ); Tue, 19 Apr 2022 06:51:45 -0400 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 58DD82A251; Tue, 19 Apr 2022 03:49:03 -0700 (PDT) Received: from NTHCCAS01.nuvoton.com (NTHCCAS01.nuvoton.com [10.1.8.28]) by maillog.nuvoton.com (Postfix) with ESMTP id 8BA9F1C8111A; Tue, 19 Apr 2022 18:49:02 +0800 (CST) Received: from NTHCML01B.nuvoton.com (10.1.8.178) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Tue, 19 Apr 2022 18:49:02 +0800 Received: from NTHCCAS04.nuvoton.com (10.1.8.29) by NTHCML01B.nuvoton.com (10.1.8.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 19 Apr 2022 18:49:02 +0800 Received: from [172.19.1.47] (172.19.1.47) by NTHCCAS04.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 19 Apr 2022 18:49:01 +0800 Message-ID: Date: Tue, 19 Apr 2022 18:49:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Content-Language: en-US To: Krzysztof Kozlowski , , , , , CC: , , , , , , , References: <20220418082738.11301-1-ychuang3@nuvoton.com> <20220418082738.11301-3-ychuang3@nuvoton.com> <2f8d2f6a-32dc-15cc-321c-f75721edf8a2@linaro.org> <29b00c24-681a-7f6f-f27d-b7525c5b8485@nuvoton.com> From: Jacky Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2022/4/19 下午 06:39, Krzysztof Kozlowski wrote: > On 19/04/2022 12:12, Jacky Huang wrote: >>>> + >>>> + assigned-clock-rates: >>>> + minItems: 5 >>>> + maxItems: 5 >>>> + >>>> + nuvoton,clk-pll-mode: >>>> + A list of PLL operation mode corresponding to DDRPLL, APLL, EPLL, >>>> + and VPLL in sequential. >>> This does not look like a binding which was tested. Read >>> "writing-schema" and test your bindings. >> "nuvoton,clk-pll-mode" is a nonstandard property used to describe the >> operation mode of >> corresponding PLLs. >> >> (According to Device tree Specification section "2.2.4 Properties" >> Nonstandard property names should specify a unique string prefix, such >> as a stock ticker symbol, identifying the name of >> the company or organization that defined the property. Examples: > I am not saying about property name. I replied under some description > below which fails to build. > > Instead please test your bindings. > > Best regards, > Krzysztof OK, I got it. I found the error by dt_binding_check. I will fix them in the next version. Thank you very much. Jacky Huang