Re: [PATCH 05/16] clk: qcom: smd-rpm: use msm8998_ln_bb_clk2 for qcm2290 SoC

Konrad Dybcio
2022-12-05T11:18:18Z

On 03/12/2022 18:57, Dmitry Baryshkov wrote:
> The qcm2290's ln_bb_clk2 is identical to the freshly added msm8998's
> ln_bb_clk2 one. Use the latter and drop the SoC-specific version.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> drivers/clk/qcom/clk-smd-rpm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index 42d55bf35a33..6af0753454ea 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -1167,7 +1167,6 @@ static const struct rpm_smd_clk_desc rpm_clk_sm6375 = {
> };
>
> /* QCM2290 */
> -DEFINE_CLK_SMD_RPM_XO_BUFFER(qcm2290, ln_bb_clk2, ln_bb_clk2_a, 0x2, 19200000);
> DEFINE_CLK_SMD_RPM_XO_BUFFER(qcm2290, rf_clk3, rf_clk3_a, 6, 38400000);
>
> DEFINE_CLK_SMD_RPM(qcm2290, cpuss_gnoc_clk, cpuss_gnoc_a_clk,
> @@ -1184,8 +1183,8 @@ static struct clk_smd_rpm *qcm2290_clks[] = {
> [RPM_SMD_BIMC_A_CLK] = &msm8916_bimc_a_clk,
> [RPM_SMD_QDSS_CLK] = &sm6125_qdss_clk,
> [RPM_SMD_QDSS_A_CLK] = &sm6125_qdss_a_clk,
> - [RPM_SMD_LN_BB_CLK2] = &qcm2290_ln_bb_clk2,
> - [RPM_SMD_LN_BB_CLK2_A] = &qcm2290_ln_bb_clk2_a,
> + [RPM_SMD_LN_BB_CLK2] = &msm8998_ln_bb_clk2,
> + [RPM_SMD_LN_BB_CLK2_A] = &msm8998_ln_bb_clk2_a,
> [RPM_SMD_RF_CLK3] = &qcm2290_rf_clk3,
> [RPM_SMD_RF_CLK3_A] = &qcm2290_rf_clk3_a,
> [RPM_SMD_CNOC_CLK] = &sm6125_cnoc_clk,