From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D17071A2643 for ; Tue, 29 Jul 2025 13:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753797232; cv=none; b=Fah+epqvqTvhCNZ7IQaUh7bzBpbf2hUP38qzJlfVlA5kN6AL/LB14HeEprKZbPX9ZcTZrTUKRx8OIgRgW9VRGzG9woH7WpVo3OpiFOMgYmJow6lOWXVLaPt1S89FqttBAMdgb9bSwrvFQtV5xm1L922BO7XB1ta9X60OjDLMKr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753797232; c=relaxed/simple; bh=7KGd7j82dDK+ybam3fPzsTNJLqBsuymq0GgV9H6+e4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r17kTa2mvFeJ1jCq7LPTZRfJAUWR0e+Awa/0py7Q0zSBah/2+amsM0LeeSa3Al4yyi8vALHykvv9+D0d1YwuViRFqtol5nwFFwrGrxKNyX13cvJOgt48MlHgZvFHhYS4HltuMNkMFjTMbvP8bathJSH8ilnHuRO842mJK9knY60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f8uyGyDb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f8uyGyDb" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56T9UaGa006916 for ; Tue, 29 Jul 2025 13:53:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uIz2sC5rEvjeL5lDn/RzFAavsZ2n0Q13ZJnx4oJFPBI=; b=f8uyGyDbhemwKOn8 iFRaSRVt3n5zuPyusne6/n6UyImffomcNSmo7wRFQ8O+DHCdGM+s56Tybz2Yd5nt fXI/5YpxUJow8wXke+xRfygm4WEsrJC6wGzoEKdJ2svj1QOsoyXNbjoAw7ZpbGUs +psQp2QXMj0Ip7Txngg0jOc0jlN3NOTUcmCoh6qVlSdjgFMVWQ+ebEqvGRilmTci 5jijlFQKSrlhVHEyBGHXV7ccxUA3odPaj23e+8nu4bVduvmWNqiUdlbu+4FZ2wT2 Y2EQizrsFzP5FgrtW4JDMCwg7J9Vm13eR+ojDCuIE5DrKIJRan5oR6qGJv3qN1ix HZdDrA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484mcr8ff3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 29 Jul 2025 13:53:49 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7e2b5396898so27182485a.0 for ; Tue, 29 Jul 2025 06:53:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753797229; x=1754402029; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uIz2sC5rEvjeL5lDn/RzFAavsZ2n0Q13ZJnx4oJFPBI=; b=mdH1acyN1iouvXSQLdjBRKK93hPmy2V2hZaPOJGZXg1zSzwvN6ES81fMuHfqBQI02i quD1ZFA00Zn4XM8MswyRSflfe+/UAXetlcv8ZxD7+IcoZtlnwEv3AS9RoZGEoM8f2z1t rgozA01ogECVTg1fs+3b/UP0WXhCGEQeIIeWgrNcf7ECzN/HQdfNTKLYTGGyxCh9cJ7L bNNyzno1f8RySRJMRMQ5iVXW8mho0fjIgcK77OSUQb2ixGyfxgIFZYZMQotVDx4dNxIe Q35IhKmjRnls849fmtV5bN4TtWLwlRxf+Ok2JFkfcTusDuI30invKy21eDEFfDlvDAtD Vzqg== X-Forwarded-Encrypted: i=1; AJvYcCUF5pk7VTTPU74jmTOpzu8VXcmr0WBnpaEmtAsU5i+OaTnPpmxKrFlZZxtRJ7QLi9IPh80TRCZ2rdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxaJ3qPnlZ7stgh89sNdF4z/7RouR2TXDR9q+1jpPzWL+5fkJ6b GESMbqdKOVpBmtatVTSIjPzx3Oepc4ZwnpBVtKJ1zPd5hRPSHvk5IidiTgTIIkUlH6YAS2K5lPm qhiFIELv/dPMkE5r8xFILBn5HnWyfwl7awWhEpRZ4EeNIS/oC+9YcTIER1ESWIts= X-Gm-Gg: ASbGncsKja0amAoErxDbG4WUlHC372GF6h+U4qASxuqmPDXngImJveZ/fgvNR0OzHK3 EKOLOciZLMnmi9HU8cl51kZ8abnjcaff2ODamVPQM5nDNCI3plN8yCTA0W9zh1h4aNlEKPyx0mH ZiSFiA5f++672q9EcGmI8zVdlej/AcUqxFdVqicGcl9fdg1NWWJtG7L1zntKFr/loRFJLTOuEu5 kSqGDXMdbDlsC9SV7sY2wneeFSIuRz4iUZq7YUEkp5yxtSgzJT4nhkTLZl6JWrA+ozLcCUK4YLo fFBAaEMVixN62+mhrYc/PyduvhTRY/3j48sCba2EYFIbt/G3FCPZejB7EzmIPbn7j7arXwzixp7 YgTgZHGg9+V+SFdKRwQ== X-Received: by 2002:a05:620a:4502:b0:7e3:2e02:4849 with SMTP id af79cd13be357-7e66d73f600mr4096685a.9.1753797228630; Tue, 29 Jul 2025 06:53:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2rZ50HIoP3F9/NtATSvU3RTcoTLz7GUYh9uMTOF98nuj610nPOwpQK2hdrfHtttMfHeiLQw== X-Received: by 2002:a05:620a:4502:b0:7e3:2e02:4849 with SMTP id af79cd13be357-7e66d73f600mr4093185a.9.1753797228016; Tue, 29 Jul 2025 06:53:48 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6156591fe7bsm1187250a12.51.2025.07.29.06.53.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Jul 2025 06:53:47 -0700 (PDT) Message-ID: Date: Tue, 29 Jul 2025 15:53:43 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/10] dt-bindings: clock: ipq9574: Rename NSS CC source clocks to drop rate To: Luo Jie , Rob Herring , Krzysztof Kozlowski Cc: Georgi Djakov , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Michael Turquette , Stephen Boyd , Anusha Rao , Konrad Dybcio , Philipp Zabel , Richard Cochran , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_pavir@quicinc.com, quic_suruchia@quicinc.com References: <20250710-qcom_ipq5424_nsscc-v3-0-f149dc461212@quicinc.com> <20250710-qcom_ipq5424_nsscc-v3-5-f149dc461212@quicinc.com> <20250710225412.GA25762-robh@kernel.org> <93082ccd-40d2-4a6b-a526-c118c1730a45@oss.qualcomm.com> <2f37c7e7-b07b-47c7-904b-5756c4cf5887@quicinc.com> <830f3989-d1ac-4b7c-8888-397452fe0abe@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <830f3989-d1ac-4b7c-8888-397452fe0abe@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI5MDEwNyBTYWx0ZWRfXwoe/5847omjf UoHXd6Wq2qndokqaR41UfXkG2e3AqR3Hrv4tIrtSw7AEYSnBi2SC3xlX9HSoNTr6SCNsbZqkxgy NwYT4pMRNUcIeAdrA2B+fk5qanl2xkQuubtJPKC8uCacWri7nU5TOgceQihCoTVCsrkRM4e2trS HgjUnD/40Q/tWfMi8TCyKcdEjW/WAXONUi6gqzdBEGvNriV+itIJi70OYpEf/8dvyVMS5lAziPh kvEFfRRkbjTYGRUwwMGnWbDmHxyutKLj+OP/kryKVQxHA5LTOQCFKAQ1yPsO2+nnI3t1TBowrwR Jk6XJSrujfW1+ZtP3OZKaAAY8nmxmU/6RflMWd/8xN+MnqgPrzClZuDyO0JzUE9cC6rwfbrqTWO ajKZmsajYHWqCdLl3xAAfsQ8L6bTPvECszJUzGP9XrEaAk1oJooY2XpgRBZQ01rHhQ/uDVTR X-Authority-Analysis: v=2.4 cv=Hth2G1TS c=1 sm=1 tr=0 ts=6888d26d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=RShGOoz45MAMUC7vXQcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: eoJT4aiXiV9eOsEmgyq-IRclBIkXBL3L X-Proofpoint-ORIG-GUID: eoJT4aiXiV9eOsEmgyq-IRclBIkXBL3L X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-29_03,2025-07-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 clxscore=1015 spamscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507290107 On 7/18/25 5:51 PM, Luo Jie wrote: > > > On 7/18/2025 5:28 PM, Konrad Dybcio wrote: >> On 7/18/25 11:12 AM, Luo Jie wrote: >>> >>> >>> On 7/11/2025 8:15 PM, Konrad Dybcio wrote: >>>> On 7/11/25 12:54 AM, Rob Herring wrote: >>>>> On Thu, Jul 10, 2025 at 08:28:13PM +0800, Luo Jie wrote: >>>>>> Drop the clock rate suffix from the NSS Clock Controller clock names for >>>>>> PPE and NSS clocks. A generic name allows for easier extension of support >>>>>> to additional SoCs that utilize same hardware design. >>>>> >>>>> This is an ABI change. You must state that here and provide a reason the >>>>> change is okay (assuming it is). Otherwise, you are stuck with the name >>>>> even if not optimal. >>>> >>>> The reason here seems to be simplifying the YAML.. which is not a good >>>> reason really.. >>>> >>>> I would instead suggest keeping the clocks list as-is for ipq9574 (this >>>> existing case), whereas improving it for any new additions >>>> >>>> Konrad >>> >>> Thanks Rob and Konrad for the comments. >>> >>> "nss_1200" and "nss" refer to the same clock pin on different SoC. >>> As per Krzystof's previous comment on V2, including the frequency >>> as a suffix in the clock name is not required, since only the >>> frequencies vary across different IPQ SoCs, while the source clock >>> pins for 'PPE' and 'NSS' clocks are the same. Hence this ABI change >>> was deemed necessary. >>> >>> By removing the frequency suffix, the device tree bindings becomes >>> more flexible and easier to extend for supporting new hardware >>> variants in the future. >>> >>> Impact due to this ABI change: The NSS clock controller node is only >>> enabled for the IPQ9574 DTS. In this patch series, the corresponding >>> DTS changes for IPQ9574 are also included to align with this ABI >>> change. >> >> The point of an ABI is to keep exposing the same interface without >> any change requirements, i.e. if a customer ships the DT from >> torvalds/master in firmware and is not willing to update it, they >> can no longer update the kernel without a workaround. >> >>> Please let me know if further clarification or adjustments are needed. >> >> What we're asking for is that you don't alter the name on the >> existing platform, but use a no-suffix version for the ones you >> introduce going forward >> >> i.e. (pseudo-YAML) >> >> if: >>    properties: >>      compatible: >>        - const: qcom,ipq9574-nsscc >> then: >>    properties: >>      clock-names: >>        items: >>          - clockname_1200 >> else: >>    properties: >>      clock-names: >>        items: >>          - clockname # no suffix >> >> Konrad > > We had adopted this proposal in version 2 previously, but as noted in > the discussion linked below, Krzysztof had suggested to avoid using the > clock rate in the clock names when defining the constraints for them. > However I do agree that we should keep the interface for IPQ9574 > unchanged and instead use a generic clock name to support the newer > SoCs. > > https://lore.kernel.org/all/20250701-optimistic-esoteric-swallow-d93fc6@krzk-bin/ > > Request Krzysztof to provide his comments as well, on whether we can > follow your suggested approach to avoid breaking ABI for IPQ9574. Krzysztof, should the bindings be improved-through-breaking, or should there simply be a new YAML with un-suffixed entries, where new platforms would be added down the line? Konrad