From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/9] clk: davinci: psc-dm365: use two lookup entries for the aemif clock To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , Russell King , Michael Turquette , Stephen Boyd , Linux ARM , Linux Kernel Mailing List , linux-clk , Bartosz Golaszewski References: <20180625152920.11549-1-brgl@bgdev.pl> <20180625152920.11549-2-brgl@bgdev.pl> <241fed6e-b414-feac-8e6c-39713c5e665e@lechnology.com> From: David Lechner Message-ID: Date: Mon, 25 Jun 2018 11:06:46 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 06/25/2018 11:01 AM, Bartosz Golaszewski wrote: > 2018-06-25 17:53 GMT+02:00 David Lechner : >> On 06/25/2018 10:29 AM, Bartosz Golaszewski wrote: >>> >>> From: Bartosz Golaszewski >>> >>> We want to be able to get the clock both from the board file by its >>> con_id and from the aemif driver by dev_id. >> >> >> What about the other SoCs? Don't they need this change as well? >> > > So I double checked and turns out I missed one other board that's > affected by this series and calls clk_get() from machine code: > dm644x-evm. > > I'll fix it in v2. The ti-aemif platform driver also does clk_get(). Don't you need lookups to make that work as well? For example, DA830 doesn't have a clock lookup for aemif at all.