public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Runyang Chen <runyang.chen@mediatek.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
	Runyang Chen <runyang.chen@mediatek.com>
Subject: Re: [PATCH v2 2/2] clk: mediatek: reset: add infra_ao reset support for MT8188
Date: Wed, 10 May 2023 14:20:28 -0700	[thread overview]
Message-ID: <ca1e1df877652808ef76851d7f2ed781.sboyd@kernel.org> (raw)
In-Reply-To: <20230505131308.27190-3-runyang.chen@mediatek.com>

Quoting Runyang Chen (2023-05-05 06:13:08)
> @@ -176,9 +177,32 @@ static const struct mtk_gate infra_ao_clks[] = {
>                        "infra_ao_aes_msdcfde_0p", "top_aes_msdcfde", 18),
>  };
>  
> +static u16 infra_ao_rst_ofs[] = {

const?

> +       INFRA_RST0_SET_OFFSET,
> +       INFRA_RST1_SET_OFFSET,
> +       INFRA_RST2_SET_OFFSET,
> +       INFRA_RST3_SET_OFFSET,
> +       INFRA_RST4_SET_OFFSET,
> +};
> +
> +static u16 infra_ao_idx_map[] = {

const?

> +       [MT8188_INFRA_RST1_THERMAL_MCU_RST] = 1 * RST_NR_PER_BANK + 2,
> +       [MT8188_INFRA_RST1_THERMAL_CTRL_RST] = 1 * RST_NR_PER_BANK + 4,
> +       [MT8188_INFRA_RST3_PTP_CTRL_RST] = 3 * RST_NR_PER_BANK + 5,
> +};
> +
> +static struct mtk_clk_rst_desc infra_ao_rst_desc = {
> +       .version = MTK_RST_SET_CLR,
> +       .rst_bank_ofs = infra_ao_rst_ofs,
> +       .rst_bank_nr = ARRAY_SIZE(infra_ao_rst_ofs),
> +       .rst_idx_map = infra_ao_idx_map,
> +       .rst_idx_map_nr = ARRAY_SIZE(infra_ao_idx_map),
> +};
> +
>  static const struct mtk_clk_desc infra_ao_desc = {
>         .clks = infra_ao_clks,
>         .num_clks = ARRAY_SIZE(infra_ao_clks),
> +       .rst_desc = &infra_ao_rst_desc,
>  };

  reply	other threads:[~2023-05-10 21:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 13:13 [PATCH v2 0/2] Add infra_ao reset support for MT8188 Soc Runyang Chen
2023-05-05 13:13 ` [PATCH v2 1/2] dt-bindings: reset: mt8188: add thermal reset control bit Runyang Chen
2023-05-05 13:24   ` Krzysztof Kozlowski
2023-05-05 13:13 ` [PATCH v2 2/2] clk: mediatek: reset: add infra_ao reset support for MT8188 Runyang Chen
2023-05-10 21:20   ` Stephen Boyd [this message]
2023-05-25  6:46     ` Runyang Chen (陈润洋)
2023-05-25  7:12     ` Runyang Chen (陈润洋)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca1e1df877652808ef76851d7f2ed781.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=runyang.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox