From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Conor Dooley <conor@kernel.org>,
"Hal Feng" <hal.feng@starfivetech.com>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v1] clk: starfive: jh7110-sys: Set PLL0 rate to 1.5GHz
Date: Mon, 14 Aug 2023 11:06:05 +0800 [thread overview]
Message-ID: <cace0094-948b-a4e9-ab63-6fdfb9952b44@starfivetech.com> (raw)
In-Reply-To: <20230811-jiffy-nebula-a8ea5ef15eee@wendy>
On 2023/8/11 14:43, Conor Dooley wrote:
> On Fri, Aug 11, 2023 at 11:36:31AM +0800, Xingyu Wu wrote:
>> Set PLL0 rate to 1.5GHz.
>
> Why are you doing that though?
Because the CPU frequency scaling is based on 1.5GHz rate on JH7110 SoC.
And now the PLL clock driver has been accepted and PLL0 is just 1GHz[1].
[1] https://github.com/starfive-tech/VisionFive2/issues/55
We should set the PLL0 rate to a correct rate (1.5GHz) and then
the CPUfreq will work normally.
Best regards,
Xingyu Wu
>
>
>> Change the parent of cpu_root clock
>> and the divider of cpu_core before setting.
>>
>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>> ---
>>
>> Hi Stephen and Emil,
>>
>> This patch sets PLL0 rate to 1.5GHz. In order not to affect the cpu
>> operation, the cpu_root's parent clock should be changed first.
>> And the divider of the cpu_core clock should be set to 2 so they
>> won't crash when setting 1.5GHz without voltage regulation.
>>
>> This patch is based on linux-next which has merge PLL driver on
>> StarFive JH7110 SoC.
>>
>> Thanks,
>> Xingyu Wu
next prev parent reply other threads:[~2023-08-14 3:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 3:36 [PATCH v1] clk: starfive: jh7110-sys: Set PLL0 rate to 1.5GHz Xingyu Wu
2023-08-11 6:43 ` Conor Dooley
2023-08-14 3:06 ` Xingyu Wu [this message]
2023-08-14 6:57 ` Conor Dooley
2023-08-14 7:28 ` Xingyu Wu
2023-08-14 7:34 ` Hal Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cace0094-948b-a4e9-ab63-6fdfb9952b44@starfivetech.com \
--to=xingyu.wu@starfivetech.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox