Re: [PATCH v3 22/28] ARM: dts: qcom: apq8064: add simple CPUFreq support

Konrad Dybcio
2023-07-03T11:31:00Z

On 2.07.2023 19:42, Dmitry Baryshkov wrote:
> Declare CPU frequency-scaling properties. Each CPU has its own clock,
> how all CPUs have the same OPP table. Voltage scaling is not (yet)
> enabled with this patch. It will be enabled later.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
[...]

>
> + cpu_opp_table: opp-table-cpu {
> + compatible = "operating-points-v2-krait-cpu";
> + nvmem-cells = <&speedbin_efuse>;
> +
> + /*
> + * Voltage thresholds are <target min max>
> + */
/* Voltage thresholds are <target min max> */

> + opp-384000000 {
> + opp-hz = /bits/ 64 <384000000>;
> + opp-peak-kBps = <384000>;
> + opp-microvolt-speed0-pvs0 = <950000 950000 975000>;
> + opp-microvolt-speed0-pvs1 = <925000 900000 950000>;
> + opp-microvolt-speed0-pvs3 = <875000 850000 900000>;
>
[...]

> +
> memory@0 {
> device_type = "memory";
> reg = <0x0 0x0>;
> @@ -834,6 +1313,9 @@ qfprom: qfprom@700000 {
> #address-cells = <1>;
> #size-cells = <1>;
> ranges;
> + speedbin_efuse: speedbin@c0 {
> + reg = <0x0c0 0x4>;
no bits=<>?

> + };
Newline between properties & subnodes and between each subnode, please

lgtm otherwise, although I'm not checking these magic volt values

Konrad
> tsens_calib: calib@404 {
> reg = <0x404 0x10>;
> };