Linux clock framework development
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Joel Stanley <joel@jms.id.au>
Cc: linux-aspeed@lists.ozlabs.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	Dylan Hung <dylan_hung@aspeedtech.com>,
	Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH v4 5/5] dt-bindings: clock: ast2600: Add reset config for I3C
Date: Wed, 01 Mar 2023 14:28:59 +0800	[thread overview]
Message-ID: <cbbb99ce6125048667e4c41412710a61dc4d686f.camel@codeconstruct.com.au> (raw)
In-Reply-To: <CACPK8XcA_SES=Wo7vuWEJ4U5kTizM5brmb=6ELXD-taCFJQwgA@mail.gmail.com>

Hi Joel,

> > diff --git a/include/dt-bindings/clock/ast2600-clock.h
> > b/include/dt-bindings/clock/ast2600-clock.h
> > index b4d69103d722..b1c129977910 100644
> > --- a/include/dt-bindings/clock/ast2600-clock.h
> > +++ b/include/dt-bindings/clock/ast2600-clock.h
> > @@ -90,6 +90,12 @@
> >  /* Only list resets here that are not part of a gate */
> 
> These definitions are part of a gate, yeah?

Well, no more "part of a gate" than all of the other definitions :)

All the defines in this section are references to individual bits in
the reset register banks in SCU040 & SCU050; the i3c set are the same
as the others there.

So I'm not sure what that comment is supposed to signify as to what
qualifies as a "gate" in the context of a reset...

Cheers,


Jeremy

  reply	other threads:[~2023-03-01  6:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28  9:16 [PATCH v4 0/5] Add definitions for AST2600 i3c clocks and resets Jeremy Kerr
2023-02-28  9:16 ` [PATCH v4 1/5] clk: ast2600: allow empty entries in aspeed_g6_gates Jeremy Kerr
2023-03-01  0:50   ` Joel Stanley
2023-02-28  9:16 ` [PATCH v4 2/5] dt-bindings: clock: ast2600: Add top-level I3C clock Jeremy Kerr
2023-02-28 10:07   ` Krzysztof Kozlowski
2023-03-01  0:51   ` Joel Stanley
2023-02-28  9:16 ` [PATCH v4 3/5] clk: ast2600: Add full configs for I3C clocks Jeremy Kerr
2023-03-01  0:48   ` Joel Stanley
2023-03-01  0:58     ` Jeremy Kerr
2023-03-01  1:06       ` Joel Stanley
2023-03-01  8:17       ` Jeremy Kerr
2023-02-28  9:16 ` [PATCH v4 4/5] dt-bindings: clock: ast2600: remove IC36 & I3C7 clock definitions Jeremy Kerr
2023-03-01  0:48   ` Joel Stanley
2023-02-28  9:16 ` [PATCH v4 5/5] dt-bindings: clock: ast2600: Add reset config for I3C Jeremy Kerr
2023-03-01  0:49   ` Joel Stanley
2023-03-01  6:28     ` Jeremy Kerr [this message]
2023-03-01  6:48       ` Joel Stanley
2023-03-01  6:54         ` Jeremy Kerr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbbb99ce6125048667e4c41412710a61dc4d686f.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=andrew@aj.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=dylan_hung@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox