From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F556C433F5 for ; Fri, 8 Apr 2022 15:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234109AbiDHPbj (ORCPT ); Fri, 8 Apr 2022 11:31:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237598AbiDHPbf (ORCPT ); Fri, 8 Apr 2022 11:31:35 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7FDD11DD19 for ; Fri, 8 Apr 2022 08:29:31 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id w21so13486354wra.2 for ; Fri, 08 Apr 2022 08:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod-ie.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ifY6DMbLg1SCliDlEYY8vn7YQNz7rwzE6gWMsXWpwWQ=; b=f+pyN4QcTJS1ikUlp6zjJcPGoEm4rBGxHM19/nqQZbVxnOqEcOk2tnU1AWTctJfUBJ fv/a+ioFkF8LckXVZPc4njJ05ACyEe7V2pw8eBC9HuIGeKsEUjJtdKrcOq5XKn/Nedgy MHpAJG7Ww/lDRZHMBeJj3zDtNFQrJjDPZv2aki1LdrTy1FIF3azC8RVqVNXxL/yCBmMX AUV/MQTx+o96TemNGq3MEXkq+vSI2R841mjlTLWdta3s3sw1pNv/75mudQVfVyEGZyBa 0F+N0emulepgjY3lCG0t36N9cFBgVe/dxYBjr8T5HozlaUYA0BJKml00E+I5AQk+aWOM RGVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ifY6DMbLg1SCliDlEYY8vn7YQNz7rwzE6gWMsXWpwWQ=; b=ZefbklU9ldVumumc5lp8BXLOjsTwtKMzpwgsYLXGW+RMZd6gTReqKL3VhXyj9BIHfk 2VWPGwJShVEPmWj+Z04qCp0ZhSf0MiVf2tOLfRMgLSUm3UgBIq0CrygD9LneYx13AqJr rPDUuXp3qdDY2UzRBnCWUc6XgMhZ32z9jIx5hpm0lpS6ubACW6rHuzB+Ct4eC3XhR2ZJ TmMTmUz+VpYmBoboRQmKuXkeDzD0q7T8N/3BF5mZMixz3pDy/VqeKFBKsbeZevX55RWH btDGZ3wgsUleovLCyXnqgGnXjZmz2v0e2RgIGq0ca0iD8hGTNCVmpmvE0NhksXxsxheG 7/sw== X-Gm-Message-State: AOAM530WKpHBVKH3Z9gb28M8oR6ygvi7VdKENpoD4c2H/1PJTHbQin54 y5GSeoymUlcQ0QAQN08PaSeX4w== X-Google-Smtp-Source: ABdhPJze7wG69pOLr7bONpv65bzq93TZexBOiF5c8eNlAqorPQ/UAQk7C54nPkcIOHDXC/mmjbKaaw== X-Received: by 2002:a05:6000:1848:b0:204:e92:5af6 with SMTP id c8-20020a056000184800b002040e925af6mr14917867wri.180.1649431770416; Fri, 08 Apr 2022 08:29:30 -0700 (PDT) Received: from [192.168.2.222] ([51.37.209.28]) by smtp.gmail.com with ESMTPSA id p14-20020a05600c1d8e00b0038dbb5ecc8asm10965530wms.2.2022.04.08.08.29.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 08:29:29 -0700 (PDT) Message-ID: Date: Fri, 8 Apr 2022 16:29:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v1 0/7] Add rtc refclk support for PolarFire SoC Content-Language: en-US To: Krzysztof Kozlowski , Conor Dooley , mturquette@baylibre.com, sboyd@kernel.org, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, palmer@rivosinc.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzk+dt@kernel.org Cc: daire.mcnamara@microchip.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220408143646.3693104-1-conor.dooley@microchip.com> <1fa15b36-7a84-e0ac-2c56-d6a2bec566ff@linaro.org> From: Conor Dooley In-Reply-To: <1fa15b36-7a84-e0ac-2c56-d6a2bec566ff@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 08/04/2022 15:57, Krzysztof Kozlowski wrote: > On 08/04/2022 16:36, Conor Dooley wrote: >> Hey, >> As I mentioned in my fixes for 5.18 [0], found out that the reference >> clock for the rtc is actually missing from the clock driver (and the >> dt binding). >> >> Currently the mpfs clock driver uses a reference clock called the >> "msspll", set in the device tree, as the parent for the cpu/axi/ahb >> (config) clocks. The frequency of the msspll is determined by the FPGA >> bitstream & the bootloader configures the clock to match the bitstream. >> The real reference is provided by a 100 or 125 MHz off chip oscillator. >> >> However, the msspll clock is not actually the parent of all clocks on >> the system - the reference clock for the rtc/mtimer actually has the >> off chip oscillator as its parent. >> >> This series enables reading the rate of the msspll clock, converts >> the refclock in the device tree to the external reference & adds >> the missing rtc reference clock. >> >> I assume it is okay not to add fixes tags for the rtc dt binding? >> Since the clock was previously missing, the binding is wrong, but >> idk if that qualifies as a fix? > > Usually ABI breakage, even if accepted, should be be tagged as fix > because it is clearly then a break of other peoples' trees... > That means either a) do something messy in the clock driver or b) mark the whole series as fixes (and roll it into [0]). The second option seems far more sensible to me, do you agree?