From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Bryan O'Donoghue <bod@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v10 1/7] dt-bindings: media: qcom,x1e80100-camss: Add simple-mfd compatible
Date: Mon, 16 Mar 2026 04:12:35 +0200 [thread overview]
Message-ID: <cca53190-ec16-40ee-ab4d-7bfbc1f082e8@linaro.org> (raw)
In-Reply-To: <20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-1-fdfe984fe941@linaro.org>
On 3/16/26 03:02, Bryan O'Donoghue wrote:
> Add "simple-mfd" as a second compatible string to allow child nodes
> within the CAMSS block to probe as individual platform devices.
Why are there any child nodes representing platform devices?
There is no necessity of it, please use a layout similar to CAMSS CCI
modelling.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> index 2d1662ef522b7..b5654ef71bd89 100644
> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> @@ -14,7 +14,11 @@ description:
>
> properties:
> compatible:
> - const: qcom,x1e80100-camss
> + oneOf:
> + - const: qcom,x1e80100-camss
> + - items:
> + - const: qcom,x1e80100-camss
> + - const: simple-mfd
>
> reg:
> maxItems: 17
> @@ -191,7 +195,7 @@ examples:
> #size-cells = <2>;
>
> camss: isp@acb7000 {
> - compatible = "qcom,x1e80100-camss";
> + compatible = "qcom,x1e80100-camss", "simple-mfd";
>
> reg = <0 0x0acb7000 0 0x2000>,
> <0 0x0acb9000 0 0x2000>,
>
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2026-03-16 2:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 1:02 [PATCH v10 0/7] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Bryan O'Donoghue
2026-03-16 1:02 ` [PATCH v10 1/7] dt-bindings: media: qcom,x1e80100-camss: Add simple-mfd compatible Bryan O'Donoghue
2026-03-16 2:12 ` Vladimir Zapolskiy [this message]
2026-03-16 2:39 ` Dmitry Baryshkov
2026-03-16 9:28 ` Vladimir Zapolskiy
2026-03-16 7:29 ` Krzysztof Kozlowski
2026-03-16 12:01 ` Bryan O'Donoghue
2026-03-17 15:51 ` Krzysztof Kozlowski
2026-03-17 16:00 ` Krzysztof Kozlowski
2026-03-17 16:21 ` Bryan O'Donoghue
2026-03-17 16:29 ` Krzysztof Kozlowski
2026-03-17 17:29 ` Bryan O'Donoghue
2026-03-17 17:32 ` Krzysztof Kozlowski
2026-03-27 12:53 ` Konrad Dybcio
2026-03-16 1:02 ` [PATCH v10 2/7] dt-bindings: media: qcom,x1e80100-camss: Add optional PHY handle definitions Bryan O'Donoghue
2026-03-16 2:07 ` Vladimir Zapolskiy
2026-03-16 2:40 ` Dmitry Baryshkov
2026-03-16 2:50 ` Rob Herring (Arm)
2026-03-16 7:31 ` Krzysztof Kozlowski
2026-03-17 5:55 ` Bryan O'Donoghue
2026-03-16 1:02 ` [PATCH v10 3/7] dt-bindings: media: qcom,x1e80100-camss: Add support for combo-mode endpoints Bryan O'Donoghue
2026-03-16 1:02 ` [PATCH v10 4/7] dt-bindings: media: qcom,x1e80100-camss: Describe iommu entries Bryan O'Donoghue
2026-03-16 7:32 ` Krzysztof Kozlowski
2026-03-16 1:02 ` [PATCH v10 5/7] media: qcom: camss: Add legacy_phy flag to SoC definition structures Bryan O'Donoghue
2026-03-16 1:02 ` [PATCH v10 6/7] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2026-03-16 1:02 ` [PATCH v10 7/7] media: qcom: camss: Drop legacy PHY descriptions from x1e Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cca53190-ec16-40ee-ab4d-7bfbc1f082e8@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox