From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C86C433EF for ; Sat, 18 Dec 2021 10:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231545AbhLRKhv (ORCPT ); Sat, 18 Dec 2021 05:37:51 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:56780 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbhLRKhu (ORCPT ); Sat, 18 Dec 2021 05:37:50 -0500 Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 0A1C14000D for ; Sat, 18 Dec 2021 10:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639823868; bh=LDSDrmQFQEPs0AYtnIdv1IgjreVq4x1VFmfenDdMBLE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IkAA1d1H5ke08ERa0RKwPDAUBIhwCP0swVSOeGeWBrBshVKgO+G06aawl3g3h9geG CJEBwn5eHceQSfLfhdbYhTd27hzYlbNNnCjaAlygU4n3TRRBKgo7YYRYElSwa9TlJm ezezcWv+4Ni/4dW0cAsRKqlup9AIiNfeEiTqt8rvbPGjK1Uqhid3tOeqCEgIKZQjeK vbkKvIQz1dhhQQvqk2IMyRXosuUKqPfas1DyO3Xs8yQt1k02ISDEfPzGEfQSk5vM93 p7Gn/0MOs9loKV3P1j1gGJHJDD0EfQMd4eBMBUaA+x49hyzWSt7OCul4qsjyX5P3RW Z3jXolp0Q94Rw== Received: by mail-lf1-f71.google.com with SMTP id h7-20020ac24da7000000b0042521f16f1fso2122309lfe.21 for ; Sat, 18 Dec 2021 02:37:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LDSDrmQFQEPs0AYtnIdv1IgjreVq4x1VFmfenDdMBLE=; b=UuPgkYuXNh7VWvpWRxO5zdgsibmQTgnGYV1jOZVy2f14dP2egjjynMDCYjaY5NRXE2 p9FCNCHKb+NFJJWIXb2tGSCphcIvjnKIttQDrNdpc2AS1O+GFrErNk3Q5RXca3TB6D0c WErfX4SjvOsw6sli1NDO5gd3yhs9saQIJtMh+kzwfdocO87jPRutIFOZF4huT7y7fpec vbuz73Vs1GCk6qt7zL3V1/9li57KjuxRCNZVYVxknIPpj15g/JZOndkZsBTXSbHluMbZ hiBZCScY1c1nvxG77quF0oO5dnvomy+HUn/PnIrq4riuPY/+rt0x5osHyemNTJn87VhI LS7w== X-Gm-Message-State: AOAM5317+jEoALiI+5UBRWQf+84GG8yBlf7WYXE3D98ky1T/8tamUX0r UXyWv/HhdAqrO7aUY9s81mKAeXseRxPwZBRf7Fet+hPo0jJP/kk537k7cjRpzXIkzP3Gu3SbThs ecEtcx60XlgIci0u73JKpegUPfCdsotGW4ZaBsQ== X-Received: by 2002:ac2:57db:: with SMTP id k27mr6746131lfo.652.1639823867320; Sat, 18 Dec 2021 02:37:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFPjW4FhzC6siK+EU1JldkI45ctb06HwBavX8cSF/Dm+d0Cp+CPDqvzJoTiq7Mk6+JWyBNUA== X-Received: by 2002:ac2:57db:: with SMTP id k27mr6746110lfo.652.1639823867154; Sat, 18 Dec 2021 02:37:47 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id b17sm1054lfq.238.2021.12.18.02.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Dec 2021 02:37:46 -0800 (PST) Message-ID: Date: Sat, 18 Dec 2021 11:37:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 6/7] arm64: dts: exynos: Add initial Exynos850 SoC support Content-Language: en-US To: Alim Akhtar , Sam Protsenko Cc: Rob Herring , Sylwester Nawrocki , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, open list , linux-clk@vger.kernel.org References: <20211215160906.17451-1-semen.protsenko@linaro.org> <20211215160906.17451-7-semen.protsenko@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 17/12/2021 17:46, Alim Akhtar wrote: > Hi Sam, > > On Thu, Dec 16, 2021 at 1:36 AM Sam Protsenko > wrote: >> >> Samsung Exynos850 is ARMv8-based mobile-oriented SoC. This patch adds >> initial SoC support. It's not comprehensive yet, some more devices will >> be added later. Right now only crucial system components and most needed >> platform devices are defined. >> >> Crucial features (needed to boot Linux up to shell with serial console): >> >> * Octa cores (Cortex-A55), supporting PSCI v1.0 >> * ARM architected timer (armv8-timer) >> * Interrupt controller (GIC-400) >> * Pinctrl nodes for GPIO >> * Serial node >> >> Basic platform features: >> >> * Clock controller CMUs >> * OSCCLK clock >> * RTC clock >> * MCT timer >> * ARM PMU (Performance Monitor Unit) >> * Chip-id >> * RTC >> * Reset >> * Watchdog timers >> * eMMC >> * I2C >> * HSI2C >> * USI >> >> All those features were already enabled and tested on E850-96 board with >> minimal BusyBox rootfs. >> >> Signed-off-by: Sam Protsenko >> --- >> .../boot/dts/exynos/exynos850-pinctrl.dtsi | 755 ++++++++++++++++++ >> arch/arm64/boot/dts/exynos/exynos850.dtsi | 755 ++++++++++++++++++ > Instead of such a large patch, it is good to logically divide the > patches as per IP for easy of review > e.g. > Put everything in one patch which is good enough to get you a Linux > prompt, followed > by one or a couple of IPs dtsi, dts entries. The patch is not that big and splitting it into several addons does not bring benefits. You still add new DTSI - either in one or two patches, there is going to be the same amount of code to review. One still has to review everything. It would be different if DTSI was already applied - then incremental updates make sense. Another reason for splitting is for different topics, when doing multiple separate actions, like fix + add, change + add. Best regards, Krzysztof