From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0ABC64EC4 for ; Fri, 3 Mar 2023 22:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233609AbjCCWRi (ORCPT ); Fri, 3 Mar 2023 17:17:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233621AbjCCWRX (ORCPT ); Fri, 3 Mar 2023 17:17:23 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EDA43D09E; Fri, 3 Mar 2023 14:08:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 026D261912; Fri, 3 Mar 2023 21:51:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5195C433EF; Fri, 3 Mar 2023 21:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677880281; bh=Br50V+ZnNhKeUVmf1H88XflaSYA3zbjNUSaOrfbHpWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L0Wgj2qDMYr7AQFFunxAnGexnwRXj41XfheavwO4sQNH9ThQWN7YWlj2Dp73Ahdw/ 2uXKlv/22ez+DVr7ejBSi69+v/MiAkOp+L5BIU6bdV3QorAgVbad15r3DUWG3n/DEN M10p5eVyq7bMRTBYHiwIAV7dwH08VMMfs8aaRdkMd/hoae6WtB50Y8/GEMWE9hfPsr X7GJJ+ZO9cmyRf0HO7C4myHQ+bm9TdwZkTHEpy9iYruGmrWIunUXZc3w5CkIZpxxYi kXKl6tYBhJNPTsNy5u9kGPM7Uf/kIR6xDR/XGWpONnVXpZwWkjJ02fE/UU6YbDF9O8 LSMB76p+PtvfA== Date: Fri, 3 Mar 2023 21:51:12 +0000 From: Conor Dooley To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Stephen Boyd , Herbert Xu , "David S. Miller" , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Thomas Gleixner , Marc Zyngier , Mauro Carvalho Chehab , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Vinod Koul , Kishon Vijay Abraham I , Mark Brown , Conor Dooley , linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, alsa-devel@alsa-project.org, linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org Subject: Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#' Message-ID: References: <20230303214223.49451-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mffVr3k4EP4yfp2t" Content-Disposition: inline In-Reply-To: <20230303214223.49451-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --mffVr3k4EP4yfp2t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote: > Enable yamllint to check the prefered commenting style of requiring a > space after a comment character '#'. Fix the cases in the tree which > have a warning with this enabled. Most cases just need a space after the > '#'. A couple of cases with comments which were not intended to be > comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and > brcm,bcmgenet.yaml. >=20 > Signed-off-by: Rob Herring > --- > Cc: Conor Dooley > diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yam= l b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml > index 1051690e3753..74a817cc7d94 100644 > --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml > @@ -22,7 +22,7 @@ properties: > - items: > - const: microchip,mpfs-qspi > - const: microchip,coreqspi-rtl-v2 > - - const: microchip,coreqspi-rtl-v2 #FPGA QSPI > + - const: microchip,coreqspi-rtl-v2 # FPGA QSPI > - const: microchip,mpfs-spi I had to think for a minute as to what that comment even meant... Reviewed-by: Conor Dooley Thanks, Conor. --mffVr3k4EP4yfp2t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZAJr0AAKCRB4tDGHoIJi 0rHgAP9euC+7Ztk0BIMgxdrJzAjogpoZQH6UzawtcdI6SIq2nQD/d5Bvci5DVqMV DWn8X2un+KM/vLbl8yUpHlGFB4QKwQY= =v1U9 -----END PGP SIGNATURE----- --mffVr3k4EP4yfp2t--