From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v9 09/27] ARM: davinci: dm644x: add new clock init using common clock framework To: David Lechner , , , CC: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , Bartosz Golaszewski , Adam Ford , References: <20180427001745.4116-1-david@lechnology.com> <20180427001745.4116-10-david@lechnology.com> From: Sekhar Nori Message-ID: Date: Thu, 3 May 2018 18:48:20 +0530 MIME-Version: 1.0 In-Reply-To: <20180427001745.4116-10-david@lechnology.com> Content-Type: text/plain; charset="utf-8" List-ID: On Friday 27 April 2018 05:47 AM, David Lechner wrote: > void __init dm644x_init_time(void) > { > +#ifdef CONFIG_COMMON_CLK > + void __iomem *pll1, *psc; > + struct clk *clk; > + > + clk_register_fixed_rate(NULL, "ref_clk", NULL, 0, DM644X_REF_FREQ); > + > + pll1 = ioremap(DAVINCI_PLL1_BASE, SZ_1K); > + dm355_pll1_init(NULL, pll1, NULL); This should be dm644x_*() > + > + psc = ioremap(DAVINCI_PWR_SLEEP_CNTRL_BASE, SZ_4K); > + dm355_psc_init(NULL, psc); This one should be dm644x_*() With those fixes, I was able to bootup on DM644x EVM and a visual inspection of clock debug dump shows it remains same before and after the conversion. Thanks, Sekhar