linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	Jacky Bai <ping.bai@nxp.com>,
	Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Robin Gong <yibin.gong@nxp.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Angus Ainslie <angus@akkea.ca>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Abel Vesa <abel.vesa@nxp.com>,
	"linux-pm@lists.infradead.org" <linux-pm@lists.infradead.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: [PATCH 0/4] imx8mm-evk: Enable CPU freq and voltage switching
Date: Fri, 12 Apr 2019 14:10:02 +0000	[thread overview]
Message-ID: <cover.1555077720.git.leonard.crestez@nxp.com> (raw)

This was sent as a series but patches can be safely applied in any order.
Without the pll_1416x bugfix cpufreq will refuse to switch.

The patch adding PMIC to DT is mostly based on our internal tree and I'm not
sure all properties are actually required. I tested that cpufreq switches
voltages safely and also SVNS mode across reset/shutdown seems to work
as expected.

There is also a naming disagreement between datasheet/schematics and
regulator driver: between BD71837 and BD71847 the BUCK3/4 regulators
were removed but datasheet and board schematics kept the names for
BUCK5/6/7/8. The driver however renumbered 5/6/7/8 to 3/4/5/6.

More concretely:

    bd71847_regulators[2].name = 'buck3'
    bd71847_regulators[2].vsel_reg = BD718XX_REG_1ST_NODVS_BUCK_VOLT
    BD718XX_REG_1ST_NODVS_BUCK_VOLT = 0x14

    bd71837_regulators[4].name = 'buck5'
    bd71837_regulators[4].vsel_reg = BD718XX_REG_1ST_NODVS_BUCK_VOLT
    BD718XX_REG_1ST_NODVS_BUCK_VOLT = 0x14

    bd71837_regulators[2].name = 'buck3'
    bd71837_regulators[2].vsel_reg = BD71837_REG_BUCK3_VOLT_RUN
    BD71837_REG_BUCK3_VOLT_RUN = 0x12

For both versions the datasheet refers to 0x14 as BUCK5_VOLT5 rather
than "1ST_NODVS_BUCK".

Using the names from DT bindings works fine.

Leonard Crestez (4):
  clk: imx: Fix PLL_1416X not rounding rates
  arm64: dts: imx8mm: Add cpufreq properties
  arm64: defconfig: Enable ROHM_BD718XX PMIC for imx8mm-evk
  arm64: dts: imx8mm-evk: Add BD71847 PMIC

 arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 145 +++++++++++++++++++
 arch/arm64/boot/dts/freescale/imx8mm.dtsi    |  30 ++++
 arch/arm64/configs/defconfig                 |   2 +
 drivers/clk/imx/clk-pll14xx.c                |   2 +-
 4 files changed, 178 insertions(+), 1 deletion(-)

-- 
2.17.1


             reply	other threads:[~2019-04-12 14:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 14:10 Leonard Crestez [this message]
2019-04-12 14:10 ` [PATCH 1/4] clk: imx: Fix PLL_1416X not rounding rates Leonard Crestez
2019-04-12 16:43   ` Stephen Boyd
2019-04-12 16:51     ` Leonard Crestez
2019-04-12 18:34       ` Stephen Boyd
2019-04-12 19:02         ` Leonard Crestez
2019-04-12 21:21   ` Stephen Boyd
2019-04-12 14:10 ` [PATCH 2/4] arm64: dts: imx8mm: Add cpufreq properties Leonard Crestez
2019-04-22  0:42   ` Shawn Guo
2019-04-12 14:10 ` [PATCH 3/4] arm64: defconfig: Enable ROHM_BD718XX PMIC for imx8mm-evk Leonard Crestez
2019-04-22  0:43   ` Shawn Guo
2019-04-12 14:10 ` [PATCH 4/4] arm64: dts: imx8mm-evk: Add BD71847 PMIC Leonard Crestez
2019-04-15  4:58   ` Vaittinen, Matti
2019-04-22  0:18   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1555077720.git.leonard.crestez@nxp.com \
    --to=leonard.crestez@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=angus@akkea.ca \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@lists.infradead.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=ping.bai@nxp.com \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).