From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD46E1F4630 for ; Thu, 24 Apr 2025 20:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745525325; cv=none; b=Kc8PLyg3ImQib+WpDm9ynTBSOnpjGiw827s8HmTX6wCNET0s9iYaRJae5TFSwqpDgcIHQwuld+9ZTjIJhffHeA1FtkNkn8KCUVfvPzfWVlRvf6hpKha8YbvmDLR2px8wOcWpr6z82AZQxCZolwgiIf4dWxUTQoBASlSfcUOH9JM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745525325; c=relaxed/simple; bh=V3f6aXPJbQijd6ipBPnSJT6DHy2KjZMx3Pjb2cb1lhk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jl4v4MF0c/VVofTlVn3Hjbf66Dicacf3rd6nJBwXFsUchwlTHDnes/2ymK0poBfxSjjNqKkcyKdiQ87+qKd4s3vO4T/aHeFQAfKWQRDQj2Hl4e1/mWX5Fhq0gt32sdfQtZavBLjWfNOMkfuxZ/XDR4OytXlk0dhFISNQ+KuE1GM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AMsspUme; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AMsspUme" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53OJnCu0027483 for ; Thu, 24 Apr 2025 20:08:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= G9NkZBB78ocYZoBuxIUW+E3P4tAq4xlMh9aXpLYJZmU=; b=AMsspUmeDDTr6fVs Zjc0G+CMRC0lqCwsh5MYoS3ndPg/wnpPgW/yQ6tV+H1CNUnOE6gzirWDXz0FSgoz fz/AChZ8VmFt5vqzIbNi5QGeLIEp9TBsnHNT9KnDKhxXd+ERhVTRcgSEhpnAkaCZ l3JIOVdpdGqZZssYB9IX6NuqWT6pfBKA6b4hNlaBHZnXODmIcEFSmCY1GYbFIccP i4VWrbvJhY/GU+K5Go0sA1Wpso9MOdkJyUaFgzTV9NXpV4nB5Y/AFKym9O50tygz VouZvcBUoITRLWpgWZUGkqed3vY6g7BKgOqGm98mYss+KpPqYYIvTjblpPgZVTnL F3mt3w== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh16qa8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 24 Apr 2025 20:08:40 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c5841ae28eso31277685a.1 for ; Thu, 24 Apr 2025 13:08:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745525319; x=1746130119; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G9NkZBB78ocYZoBuxIUW+E3P4tAq4xlMh9aXpLYJZmU=; b=n1Bqyi1JTvl7IZoTqk7VYhB2iaPkIl/RjsrkjN3mYr7BSCAuxE5WIrwrN3jOXnKS3Q Uc9U5la5smKFg9hxfVu8onoN8bQ40a4/t7ohI6/xDmH57fZ6O8ADHgXRGmoRgM8qwA1f +fvn4hj4cYYlt4pfJILLYUajY5I7nyj9gj3UUhgF5AUcWP7EytPK5o0JSaerjUKN1EcA 8K5eIuhHX43rh1v068o/0Z9TjTxJ1JN52tmMeJZs7Iaz9IbmVCxfTjOjHIujC0ZWU6AP sYD0dlNciD7LQYtWRhwCmO2TWPqDzejdIBTIeTyGwyKsOKD8YvQ8HAxhBpF/zjRvbcyD HwRw== X-Forwarded-Encrypted: i=1; AJvYcCVRbTSEm00Jxc+KslcyolcpfnCTOqi7iFfZ7ktI4lVIfU3LhRcu+gsiDueMDwb1MwWQI1GO09h5zyA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyp1BERh1DeZYjGvyDuKTCesvJqxHlJ51sF1qgxDeOFiXwB1o8i pJem3PRZzC7c/Dc2Cd2y86TaHuPzqHG0eL2EPV8byAbjQhqQnt+joLyRWWaPPE1FgkT/MMKffSG Ndhq+Znb2V4G8GI0Fnz415QpJcOPy0cPOKO5KosIy5vfy79XHLL5AWmrcGBs= X-Gm-Gg: ASbGncsmzKpd8J6CD3R7NhWSolrvt4sv3QbbMG5RIZmaHrWC0SsZ/bIZrxTDZ4INZIf 4kaqwyQg9BNOkRehE4V8EEy/lU6Qghxnc5+vmDUG6ebPzZKoG38qr2PZJkXa+QnCONfoEfl4Cl2 Fq1Fb/D1GEDHEwXZeGLGy2bTaeXKit2ctrTdapPTXtJYYMpM5j9VpaL1xlfdfR0WNLMfeAaNrzi zdoomyxF6zWhhLjLh5Jq4GGVjXcj1OElN7TdPHDKuBPNmlMiHEnmPX2CJ+RPkCp1/vaqyOLokik GSYt3NAlJsaUfS2q7tK6TAlNPsUKaOFly9x4+Gw1odNZpLtwqmdSmkI1CU3SCbHqUgU= X-Received: by 2002:a05:620a:2952:b0:7c5:ac06:af8 with SMTP id af79cd13be357-7c958375c68mr215663285a.9.1745525319583; Thu, 24 Apr 2025 13:08:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMmWKDcjybgaESS6WVurym3NYqKuP+fE4ZJpZgER8xsvh0anBTaORqzLN+6oFTx6wsgHq8Uw== X-Received: by 2002:a05:620a:2952:b0:7c5:ac06:af8 with SMTP id af79cd13be357-7c958375c68mr215660285a.9.1745525319127; Thu, 24 Apr 2025 13:08:39 -0700 (PDT) Received: from [192.168.65.221] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e41c71csm15120766b.4.2025.04.24.13.08.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 13:08:38 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 22:08:35 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/5] dt-bindings: media: Add qcom,x1e80100-camss To: Bryan O'Donoghue , Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Vladimir Zapolskiy References: <20250314-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v6-0-edcb2cfc3122@linaro.org> <20250314-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v6-2-edcb2cfc3122@linaro.org> <3ec3fd62-bf21-47e7-873c-ce151589d743@linaro.org> <54eeb470-cd90-4bc2-b415-6dea1ce2321d@linaro.org> <0ab31397-580f-4e5a-b9ad-d9bf79d29106@linaro.org> <36feffed-4558-4e59-97db-2f0e916dbfc7@linaro.org> <6a4ec36c-c003-4ce8-9433-8c12ed3188ee@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: kW0EjdPSeCY4BkusJ9bvpHiAfYBkQez7 X-Authority-Analysis: v=2.4 cv=OY6YDgTY c=1 sm=1 tr=0 ts=680a9a48 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=Wno-CeEu7Fx5tZoO0NsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: kW0EjdPSeCY4BkusJ9bvpHiAfYBkQez7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI0MDE0MCBTYWx0ZWRfX6WbrkRDL0T7m TrnLjDSwCz+ggBBgQbr12GViyn7w9R9BrijqSBtfXyCkefc06cGsXfl5dp61hfHsvZ7snnwoToK unD8J2rRgMJT3bxsS91o90I2uc0Ds1ZRrY1VAVn1Jtj4LPnkN2OSUp51ivxubzBjSAHQKHM8cYl 07gSNHIA0qXkQSnC3s4k6X81j2bXeDn3hF/j90ZepKDX1hu53BEdiyqdkTCqXHk+CVpK029XWec zEoSFyDvp/w6kymhXUz6xmHzrFBskcqUOjUSVGRrgxZl56ImyfZwIofiHfDViHMLTqjaoAaM4NF NwbID7ibIZegRgXS+REwSpCE9UM+IlXOph5h9m/6iAigQwyV8G8EBnrl88lHfvj4SkNGOi3Vp88 s3+FSboxf7FTpTzOnJm/FipoT/C00RybEo8FUR4KQdMM0/N61YtP1T2aTfvIoTMttmi93W8m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-24_09,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 clxscore=1015 malwarescore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504240140 On 4/24/25 6:13 PM, Bryan O'Donoghue wrote: > On 24/04/2025 16:54, Krzysztof Kozlowski wrote: >> On 24/04/2025 12:17, Bryan O'Donoghue wrote: >>> On 24/04/2025 11:07, Krzysztof Kozlowski wrote: >>>> On 24/04/2025 11:34, Bryan O'Donoghue wrote: >>>>> On 24/04/2025 07:40, Krzysztof Kozlowski wrote: >>>>>>> +  vdd-csiphy-0p8-supply: >>>>>> Same comment as other series on the lists - this is wrong name. There >>>>>> are no pins named like this and all existing bindings use different name. >>>>> >>>>> The existing bindings are unfortunately not granular enough. >>>>> >>>>> I'll post s series to capture pin-names per the SoC pinout shortly. >>>> How are the pins/supplies actually called? >>>> >>>> Best regards, >>>> Krzysztof >>> >>> I don't think strictly algning to pin-names is what we want. >>> >>> Here are the input pins >>> >>> VDD_A_CSI_0_1_1P2 >>> VDD_A_CSI_2_4_1P2 >>> VDD_A_CSI_0_1_0P9 >>> VDD_A_CSI_2_4_0P9 >>> >>> I think the right way to represent this >>> >>> yaml: >>> csiphy0-1p2-supply >>> csiphy1-1p2-supply >> >> But there is no separate supply for csiphy0 and csiphy1. Such split >> feels fine if you have separate CSI phy device nodes, which now I wonder >> - where are they? >> >> Best regards, >> Krzysztof > > The main hardware argument for it is probably these PHYs do live inside of the TITAN_TOP_GDSC power-domain, which is the same collapsible power-domain that all of the other CAMSS components live inside of. > > As I recall we had a four way - albeit long discussion on this in Dublin, you, me, Vlad and Neil and my memory was we would implement multiple rails in the existing CAMSS PHY structure and then look at how to model the PHYs differently in DTS. > > The Test Pattern Generators - TPGs would then also fit into this new model for the PHYs. Maybe we could consider modeling various camss subdevices as separate DT nodes, perhaps on some sort of a `camss` simple-pm-bus or something alike Konrad