From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA55C433FE for ; Fri, 15 Oct 2021 18:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AC1C6109E for ; Fri, 15 Oct 2021 18:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241779AbhJOSw1 (ORCPT ); Fri, 15 Oct 2021 14:52:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29613 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241733AbhJOSw0 (ORCPT ); Fri, 15 Oct 2021 14:52:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634323818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EHfGSkfyITaAcF7om32Ui+A/Q+/7gvnw6ydE61yiLsg=; b=F13VJRr00MHregXIG7tZ5+2Ccg4qRnuPPAdyivqtuXBYyPT1yUhUBq5yMKUnAJkSoXuByi /8k/x7idEgM7zk9KRvandghaunASebjlVbqoN7M8Z9nKYvHc6nRkko+VQFVAdhpPnCyZ0x NHWZTdVdZNn2UC+mccUqNUyyabT4ZHY= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-168-MjDwm4agN-mRml6EqNlJXA-1; Fri, 15 Oct 2021 14:50:17 -0400 X-MC-Unique: MjDwm4agN-mRml6EqNlJXA-1 Received: by mail-ed1-f70.google.com with SMTP id f4-20020a50e084000000b003db585bc274so9023732edl.17 for ; Fri, 15 Oct 2021 11:50:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EHfGSkfyITaAcF7om32Ui+A/Q+/7gvnw6ydE61yiLsg=; b=mSSe19M2YeuE/NbjiVH5q0YAcFeh+WY6VgXHzLdKpJ/cvQ9jvJiPZBrwlcigWOUk8o V4NnS/seZWoWzQEKQfcIENTcwsi47rqmcr6kj3bhPmca0f779/b48tHkdiJtg2zBXQro JsPalLyrsmG3P+W4CeD5rHg0rgP7XD5NaggEw5bR3ZyptBbQGhNlirnMDMzKvFlVkUyx kGGiijZ3SWh6+2fs0qymjp5sMhlrlcmfrVoIQNYKsKLAlcGKx8pook9xi2tbx5+ZtWtw E66/crULihWPoLWjniObIhGpd6TlCzixUyQdGCJgDgh/0ij94eDm2Z3Zj0mqwWbR7KUx KXXw== X-Gm-Message-State: AOAM533H0NdW8rdoy6E+XsQwlpCyWw6laIwUttCX9IF8kcPAfKnksywD u8zGGLRGi7adw0yIZ15OQRr3UxO9BrqpyOjp99xS2frAUL3Ka5NP7KnfCJu/GBWGADY2x/ML5X0 yfkz5mhG3tUDgjFRU8u955Dh3t8lygLSf+FggIod+lhJdjbaT9NZEPlqxbev/u1HjZnEq3Tq9 X-Received: by 2002:a05:6402:1d55:: with SMTP id dz21mr20443395edb.164.1634323815686; Fri, 15 Oct 2021 11:50:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWKLjhazEuITCXuU+qImt0nHN0zG7Ko1ArJLNonRV0jHASMc9XlxAIb6Ck1PU9RNfUcFNuRA== X-Received: by 2002:a05:6402:1d55:: with SMTP id dz21mr20443362edb.164.1634323815517; Fri, 15 Oct 2021 11:50:15 -0700 (PDT) Received: from x1.localdomain ([2a0e:5700:4:11:334c:7e36:8d57:40cb]) by smtp.gmail.com with ESMTPSA id fx4sm4637655ejb.113.2021.10.15.11.50.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 11:50:14 -0700 (PDT) Subject: Re: [PATCH 05/12] regulator: Introduce tps68470-regulator driver To: Mark Brown Cc: "Rafael J . Wysocki" , Mark Gross , Andy Shevchenko , Daniel Scally , Laurent Pinchart , Mauro Carvalho Chehab , Liam Girdwood , Michael Turquette , Stephen Boyd , Len Brown , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Sakari Ailus , Kate Hsuan , linux-media@vger.kernel.org, linux-clk@vger.kernel.org References: <20211008162121.6628-1-hdegoede@redhat.com> <20211008162121.6628-6-hdegoede@redhat.com> From: Hans de Goede Message-ID: Date: Fri, 15 Oct 2021 20:50:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi, On 10/15/21 6:46 PM, Mark Brown wrote: > On Mon, Oct 11, 2021 at 01:43:40PM +0200, Hans de Goede wrote: > >> To make this work when everything is build as a module patch 12/12 >> adds the following to the PMIC-MFD-driver: > >> MODULE_SOFTDEP("pre: clk-tps68470 tps68470-regulator"); > >> This will make modprobe load the clk and regulator drivers >> before it loads the main/MFD tps68470 driver. > > I feel nervous about this being reliable with all userspaces - IIRC > there was an alternative implementation of the modules stuff in > userspace and someone could always be doing insmod. OTOH without better > in kernel dependency management and/or more standards based firmware > interfaces I guess we're stuck with this. Right, this is all less then ideak, but I believe that this is the best we can do for now. Are you happy with the platform_data for this driver as defined in patch 4/12 ? : https://lore.kernel.org/platform-driver-x86/20211008162121.6628-1-hdegoede@redhat.com/T/#m745cc1191f531a57ae7998f5c8817ba9a46f0fed And are you ok with me doing an immutable-branch based on 5.15-rc1 with just the patch adding the platform_data in there ? The platform_data is used/shared by most patches in this series. So the idea is to have an immutable branch which can be shared/merged by all subsystems which have patches in this patch series. Regards, Hans