Re: [PATCH v2 3/3] clk: samsung: introduce Exynos2200 clock driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 04/03/2025 19:19, Stephen Boyd wrote:
> Quoting Ivaylo Ivanov (2025-02-23 03:56:00)
>> diff --git a/drivers/clk/samsung/clk-exynos2200.c b/drivers/clk/samsung/clk-exynos2200.c
>> new file mode 100644
>> index 000000000..151bdb35a
>> --- /dev/null
>> +++ b/drivers/clk/samsung/clk-exynos2200.c
>> @@ -0,0 +1,3928 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (C) 2025 Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
>> + * Author: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
>> + *
>> + * Common Clock Framework support for Exynos2200 SoC.
>> + */
>> +
>> +#include <linux/clk.h>
> 
> Remove this include because this is a clk provider and not a clk
> consumer.

I sent a fix for this.

> 

>> +static struct platform_driver exynos2200_cmu_driver __refdata = {
>> +       .driver = {
>> +               .name = "exynos2200-cmu",
>> +               .of_match_table = exynos2200_cmu_of_match,
>> +               .suppress_bind_attrs = true,
>> +       },
>> +       .probe = exynos2200_cmu_probe,
>> +};
>> +
>> +static int __init exynos2200_cmu_init(void)
>> +{
>> +       return platform_driver_register(&exynos2200_cmu_driver);
> 
> Was this supposed to be platform_driver_probe()? The __refdata usage
> suggests that but all of the __init markings and stuff in the samsung
> clk driver worry me.


I'll fix this and existing drivers.


Best regards,
Krzysztof