Re: [PATCH v1 5/5] clk: samsung: introduce exynos8890 clock driver

Krzysztof Kozlowski
2025-09-15T07:16:45Z

On 15/09/2025 09:49, Peng Fan wrote:
> [...]
>> +static void __init exynos8890_cmu_top_init(struct device_node *np)
>> +{
>> + exynos8890_init_clocks(np, &top_cmu_info);
>> + samsung_cmu_register_one(np, &top_cmu_info);
>> +}
>> +
>> +/* Register CMU_TOP early, as it's a dependency for other early domains */
>> +CLK_OF_DECLARE(exynos8890_cmu_top, "samsung,exynos8890-cmu-top",
>> + exynos8890_cmu_top_init);
>
> Not sure you need to run Android GKI, without module built, this platform
> will not able to support GKI.

Why would anyone worry about GKI? We develop mainline kernel, not
Android kernel.

This seems to be aligned with existing approach, no? What is different here?

Best regards,
Krzysztof