From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A79DB39B969 for ; Thu, 10 Sep 2026 07:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789024432; cv=none; b=CBeTPsjpNNP3DBXJvJZh2SYQYskfk2lSnrulbRuilP3bwSx+1yscV/WRk3eUiFSDbFtcIsJ/0NryOvILT6Vx5nTBbv+iFQtt2Hutc742puFqyW5JHIyMsvyBO3nAVSufkJIxVWeFixE516dIGX4uLESrSZBjeFsRxBVdfrlD5t0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789024432; c=relaxed/simple; bh=PXh2VO4rYITeX70Qory+PjUUOYjC1peCD6QzzIWZTGA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=jJuk+snUWsrTGI57r38QGXD+h73VmL/OnQ8iEMK2JUKjFS6IpinMErA5lDCtFzJSAhiU1scBbMuXIuBsKQ1RayOnYcM4OfUn+k/q11JoPkGW3kfVdj4O9vMRhzN44GWFlIISs/nxGwj+TBwHtO74t7oX5qyiqUzpIvHguNDeuQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XnSubBxC; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XnSubBxC" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4956869750eso59976095e9.2 for ; Thu, 10 Sep 2026 00:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1789024428; x=1789629228; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S9vc3vyc7s51kw3mexUDG6KTzAQ8qZ7SaFb2GyTr25M=; b=XnSubBxC3C1UMzn4ifsusKXQhYpLF46DzrP7kZnCbJfwQIHH+eOzVojTe2uO8Gf0zV eUvUdcWbIq0Ehq38oL1VU619DMYWI3xODqkY8zSzE63W0obJaAc4oCkBMrv5srV6C+2c waEQlw/O1VbxlaJC2zylCN5m11FSah3tIk1OR9cczLLQaefD2/PkEz+/PKl3zUUtbko1 mWkMhhApDfrjR1M6XbyN8v1J9hI1c7Q4LpiFPQD8lLab1BTK1NfhCjDKah+EO3y/LhJz 0NVegKMFCTc1L55TTDJk1MvOJ70OLesgYgmopuSTHgi2t75KPbsQxFjePWRSdynd9e0P VP8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789024428; x=1789629228; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=S9vc3vyc7s51kw3mexUDG6KTzAQ8qZ7SaFb2GyTr25M=; b=N0Fwz5RWGI4bBO+U/7ehF1y0h2L18/TqxMfQTJ8PxP4nJgDHoeCHRuzz8mO4GxJkEy IM25SGqtweWnjKuWln064TtjpURtsGWhYIT8GNPHaX4YoBFv8tGYMeRB07q8P7scVgps a2o0aTVDEi0JOQZDwzw/0RG4Ntxna7iXkgOLvz4J4gq/07oBx6xwn4lXcgkglHFR/Qy7 CIyOvjIeCeSYvZe4QfH+oZ90uz9B6QWuDUsL2DIg9XKSCe4NstP60kiZHTWxycUlD8WL VTGE7hn3G5cxRICAedYpeqECaBmlekgUAzQ5RdGgNRJTbLenPyUDlUSgZ1aSJV41cyX7 iWpw== X-Forwarded-Encrypted: i=1; AKwUvBwnbWgKum+sBy755dUv4X1H09TJVYzsHZkWIN4rOGsIlcK+xlZit3H1vLi2mD22NrsrTftEyTd/nJo=@vger.kernel.org X-Gm-Message-State: AFuF++khmtv6F8cPliXtEnQA1tXl4M+TdWcBoWm60XGxuJOXc2fmB3sh AX9rGzLDxWslhwfOtrUG43j5J0417fGXb7rdyrnRSCBFEylAAXA/YiJZAI69a1UcKMI= X-Gm-Gg: AYBFou1hmvpZqpnLkWjI3/5b5eJDj8o2IZauD7MYipHn2cQLxMKTmzlvYOQyFIbvUqb qsZqiJLhEiiSDwoyjSUASbV30g8HKhDvdl1tx0AKBdG7AmqU139jWQZBKJbHL7AMqrJcTIn2GQe Lqt3ZKP9GjehT8SeXovV1Y0UNmSMj7t5WdjovY+3aVHRtyg1BVeKZNWO+rB6BkjJFth2hY1ArGx yHdr3jYEUZVsdmz6e9d3wcVxYqSKUtzjDdOnbwJyLH51dAvXmO+nMF92hQZLfPCek79JvKzdp3E M8thbXed7WuYIFzQrJvkbgXyzNzM3HlTb7k6VymL6BFfajomwlsVIIzBy7cKoMmUbRq4yAnfld3 SRNemR+xtkMtAffPpnyhLF4MrFG78fme1o1tgwWA4K21Ri6Jj04KwQtWx7A8LuA8Z/yjlDeZwzp 1ZAIE2foNrSLQBUtN1P8RmwML8LHo2VIGFfrGb2mBEwNBijCraUKt3SCa29fVFL321XrAr2Hkkz If2wnYgvUauSn+BJAn2U//AA6j2TVxgigftgUCQvW/uBa+PfNESwz2XCmmLPPjC0Q== X-Received: by 2002:a05:600c:37c8:b0:49c:cee2:a508 with SMTP id 5b1f17b1804b1-49cf826c4e2mr379662315e9.16.1789024427828; Thu, 10 Sep 2026 00:13:47 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:3caf:d840:c911:29a9? ([2a01:e0a:106d:1080:3caf:d840:c911:29a9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4858d312ca0sm51612002f8f.4.2026.09.10.00.13.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2026 00:13:47 -0700 (PDT) Message-ID: Date: Thu, 10 Sep 2026 09:13:44 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 4/4] clk: meson: t7: don't mark sys_ampipe_nand as critical To: Lucas Tanure , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jerome Brunet , Kevin Hilman , Martin Blumenstingl , Stephen Boyd Cc: Brian Masney , Chuan Liu , Jian Hu , Ronald Claveau , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260905153234.133217-1-tanure@linux.com> <20260905153234.133217-5-tanure@linux.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260905153234.133217-5-tanure@linux.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/5/26 17:32, Lucas Tanure wrote: > sys_ampipe_nand clocks the pipeline stage inserted in the bus path > between the SD/eMMC controllers and the NIC_MATRIX fabric. It does have > identifiable consumers - the three MMC controllers - so marking it > critical was the wrong tool: the clock should be referenced from the > consumer nodes and claimed by the mmc driver instead. > > Drop the CLK_IS_CRITICAL flag and update the comment accordingly. > sys_am2axi0..2 remain critical as they clock the AXI DMA bus itself and > have no single identifiable consumer. > > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Lucas Tanure > --- > This patch depends on the MMC controllers actually referencing the clock: > the dt-bindings, mmc driver and t7 DTS changes adding the "pipeline" > clock must land before this patch, otherwise the boot hangs and memory > corruption this clock caused are reintroduced. > > drivers/clk/meson/t7-peripherals.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/meson/t7-peripherals.c b/drivers/clk/meson/t7-peripherals.c > index 55d09e78593b..2f429ea86796 100644 > --- a/drivers/clk/meson/t7-peripherals.c > +++ b/drivers/clk/meson/t7-peripherals.c > @@ -945,13 +945,13 @@ static T7_SYS_PCLK(sys_aucpu, SYS_CLK_EN0_REG0, 14, 0); > static T7_SYS_PCLK(sys_cec, SYS_CLK_EN0_REG0, 16, 0); > static T7_SYS_PCLK(sys_gdc, SYS_CLK_EN0_REG0, 17, 0); > static T7_SYS_PCLK(sys_deswarp, SYS_CLK_EN0_REG0, 18, 0); > +static T7_SYS_PCLK(sys_ampipe_nand, SYS_CLK_EN0_REG0, 19, 0); > +static T7_SYS_PCLK(sys_ampipe_eth, SYS_CLK_EN0_REG0, 20, 0); > /* > - * NOTE: sys_ampipe_nand and sys_am2axi0..2 provide the clock to the AXI bus > - * used for DMA between the peripherals and the DRAM. After the clocks are > - * disabled, a device that starts a transfer cannot complete it. > + * NOTE: sys_am2axi0..2 provide the clock to the AXI bus used for DMA between > + * the peripherals and the DRAM. After the clocks are disabled, a device that > + * starts a transfer cannot complete it. > */ > -static T7_SYS_PCLK(sys_ampipe_nand, SYS_CLK_EN0_REG0, 19, CLK_IS_CRITICAL); > -static T7_SYS_PCLK(sys_ampipe_eth, SYS_CLK_EN0_REG0, 20, 0); > static T7_SYS_PCLK(sys_am2axi0, SYS_CLK_EN0_REG0, 21, CLK_IS_CRITICAL); > static T7_SYS_PCLK(sys_am2axi1, SYS_CLK_EN0_REG0, 22, CLK_IS_CRITICAL); > static T7_SYS_PCLK(sys_am2axi2, SYS_CLK_EN0_REG0, 23, CLK_IS_CRITICAL); Reviewed-by: Neil Armstrong Thanks, Neil