From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C7CC4332F for ; Mon, 1 Nov 2021 10:49:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A768D610CB for ; Mon, 1 Nov 2021 10:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231485AbhKAKw1 (ORCPT ); Mon, 1 Nov 2021 06:52:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34313 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232066AbhKAKw0 (ORCPT ); Mon, 1 Nov 2021 06:52:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635763793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=umwT30SvHFgjwEnDiNsuyAufu0Qh656Y9Z7Z2E4XBQQ=; b=UqpoULZg9ILlPO3jspeK51i4NC56NpE+LoqUsCQp8UMW+deBN1Zrj57DY9mnmQ14Z9XVqt BXT336klt0huofMrpZxesZ/g6SdVeAG9DkYP6+F5EM4JEPIq9S6conAmiyQYpz//yWfzCK K9Zr3+bheVWvdyrocQ4uZ2Uv9bG5FlU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-562-CFYcrSDUMKWPD0dwBkjmFA-1; Mon, 01 Nov 2021 06:49:52 -0400 X-MC-Unique: CFYcrSDUMKWPD0dwBkjmFA-1 Received: by mail-ed1-f69.google.com with SMTP id g3-20020a056402424300b003e2981e1edbso651123edb.3 for ; Mon, 01 Nov 2021 03:49:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=umwT30SvHFgjwEnDiNsuyAufu0Qh656Y9Z7Z2E4XBQQ=; b=vrU8/ibfw0mqS1SsRhFKSg6nRzSf1YLXm6fKvT5Ccf3damrGXhN8exO/ucoxx9QL5C YNvW1iDFzzM3Zm7Gz6YKmBqnPY5EwSSiFJhyaT5BVF533ua3/lDKeyvLNsMuPJnH/nHO d/zvCLKcHmC9k5fmtsE0zPqzfvb7kjeh6GnFNEVE5DuJrFzQor4sjRAP5tpM2hF5z4um c2cNhaYSXKNxkCXb1oim3fIaBiT83bOW32X6V8ZXwOPsGY9Xh+Iaih2TbThC2JFx4Aan OPRrEl9rMIZ23gE8945z2NaeVCKD4JRoMwX2a9bF6Y1ZbxhKvZNevbmVqvaH4ljzMUlM 4WJw== X-Gm-Message-State: AOAM532/7GC8i0wuubdLsTBB8WGKqOU/X3+FCLZ0Ajt5Bq3Fa72MVG+Q TP7MdPm2ZxBtgRAcal6mZJkxFT2I8TYitJ47XZhKRABX/NUcjkr0de7x+2bBTsVkxhXAMAzVvwB zZdticJfm0ebBSOrvjPuW X-Received: by 2002:a05:6402:26d3:: with SMTP id x19mr4019599edd.279.1635763791081; Mon, 01 Nov 2021 03:49:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCSDOudba19n9s6P62tt/L8YmrKVyHCQhLJz3S2m5E7In4cF+zd5h+zq6clNPm6ocvlJ7nsw== X-Received: by 2002:a05:6402:26d3:: with SMTP id x19mr4019542edd.279.1635763790718; Mon, 01 Nov 2021 03:49:50 -0700 (PDT) Received: from [10.40.1.223] ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id sd28sm594119ejc.37.2021.11.01.03.49.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 03:49:50 -0700 (PDT) Message-ID: Date: Mon, 1 Nov 2021 11:49:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v4 08/11] platform/x86: int3472: Add get_sensor_adev_and_name() helper Content-Language: en-US To: Andy Shevchenko Cc: "Rafael J . Wysocki" , Mark Gross , Andy Shevchenko , Wolfram Sang , Mika Westerberg , Daniel Scally , Laurent Pinchart , Mauro Carvalho Chehab , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Len Brown , ACPI Devel Maling List , Platform Driver , Linux Kernel Mailing List , linux-i2c , Sakari Ailus , Kate Hsuan , Linux Media Mailing List , linux-clk References: <20211025094119.82967-1-hdegoede@redhat.com> <20211025094119.82967-9-hdegoede@redhat.com> <8804fa29-d0d9-14a9-e48e-268113a79d07@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi, On 11/1/21 11:46, Andy Shevchenko wrote: > On Mon, Nov 1, 2021 at 12:44 PM Andy Shevchenko > wrote: >> On Mon, Nov 1, 2021 at 12:31 PM Hans de Goede wrote: >>> On 10/25/21 13:31, Andy Shevchenko wrote: >>>> On Mon, Oct 25, 2021 at 12:42 PM Hans de Goede wrote: > > ... > >>>>> + if (ret == 0 && sensor_adev_ret) >>>>> + *sensor_adev_ret = sensor; >>>>> + else >>>>> + acpi_dev_put(sensor); >>>>> + >>>>> + return ret; > > ... > >>>> if (sensor_adev_ret) >>>> *sensor_adev_ret = sensor; >>>> >>>> return 0; >>>> >>>> ? >>> >>> That misses an acpi_dev_put(sensor) when sensor_adev_ret == NULL. >> >> else >> acpi_dev_put(...); >> >> ? > > Hmm... But then in the original code and with this proposal the > acpi_dev_put() seems a bit strange to me. > If we are fine (no error code returned) why would the caller (note > _er_) go different paths? We always need to get the dev to get the name, but some callers are only interested in the name, so they pass NULL for sensor_adev_ret, this helps to keep the code calling this clean, which is the whole idea of having a helper for this. Regards, Hans