Linux clock framework development
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>,
	cocci@inria.fr, Guru Das Srinagesh <linux@gurudas.dev>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Brian Masney <bmasney@redhat.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Stephen Boyd <sboyd@kernel.org>
Subject: Re: [cocci] [v3] coccinelle: Detect clk_register() anti-pattern
Date: Sun, 16 Aug 2026 10:38:46 +0200	[thread overview]
Message-ID: <d46f9eef-e77d-45ca-90e2-5f9f903e92d5@web.de> (raw)
In-Reply-To: <188bba40-bee-fb85-93c-fb59487dc861@inria.fr>

…
>> another issue is that in one case, removing the error message leaves:
>>
>> ret = PTR_ERR(inno->phyclk);
>> return ret;
>>
>> This could be cleaned up to just return PTR_ERR(inno->phyclk)
> Note that there are lots of occurrences of
> 
> ret = e;
> return ret;
> 
> for some expression ret and e, and 99.99% of them are fine as is.  But in
> this specific case of error handling code, perhaps it is not useful to
> introduce more of them.

Will such a development concern trigger further collateral evolution
for desirable source code transformation approaches?

Regards,
Markus

      reply	other threads:[~2026-08-16  8:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  6:33 [PATCH v3] coccinelle: Detect clk_register() anti-pattern Guru Das Srinagesh
2026-08-10  6:53 ` Julia Lawall
2026-08-10  7:13   ` Guru Das Srinagesh
2026-08-10  8:00     ` Julia Lawall
2026-08-16  8:01 ` Julia Lawall
2026-08-16  8:08   ` Julia Lawall
2026-08-16  8:38     ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d46f9eef-e77d-45ca-90e2-5f9f903e92d5@web.de \
    --to=markus.elfring@web.de \
    --cc=bmasney@redhat.com \
    --cc=cocci@inria.fr \
    --cc=julia.lawall@inria.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@gurudas.dev \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.palix@imag.fr \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox