Re: [PATCH 00/10] Initial support of MSM8937 and Xiaomi Redmi 3S

Rob Herring (Arm)
2025-02-12T14:37:57Z

On Tue, 11 Feb 2025 23:37:44 +0100, Barnabás Czémán wrote:
> This patch series add initial support for MSM8937 SoC
> and Xiaomi Redmi 3S (land).
>
> The series is extending the MSM8917 gcc and pinctrl drivers
> because they are sibling SoCs.
> MSM8937 have 4 more A53 cores and have one more dsi port then
> MSM8917.
> It implements little-big architecture and uses Adreno 505.
>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
> Barnabás Czémán (5):
> dt-bindings: mfd: qcom,tcsr: Add compatible for MSM8937
> dt-bindings: nvmem: Add compatible for MS8937
> dt-bindings: iommu: qcom,iommu: Add MSM8937 IOMMU to SMMUv1 compatibles
> dt-bindings: arm: qcom: Add Xiaomi Redmi 3S
> arm64: dts: qcom: Add Xiaomi Redmi 3S
>
> Dang Huynh (2):
> pinctrl: qcom: msm8917: Add MSM8937 wsa_reset pin
> arm64: dts: qcom: Add initial support for MSM8937
>
> Daniil Titov (3):
> dt-bindings: clock: gcc-msm8917: Split to separate schema
> dt-bindings: clock: Add MSM8937 Global Clock controller compatible
> clk: qcom: gcc: Add support for Global Clock controller found on MSM8937
>
> Documentation/devicetree/bindings/arm/qcom.yaml | 7 +
> .../bindings/clock/qcom,gcc-msm8909.yaml | 10 +-
> .../bindings/clock/qcom,gcc-msm8917.yaml | 74 +
> .../devicetree/bindings/iommu/qcom,iommu.yaml | 1 +
> .../devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
> .../devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/msm8937-xiaomi-land.dts | 402 ++++
> arch/arm64/boot/dts/qcom/msm8937.dtsi | 2145 ++++++++++++++++++++
> drivers/clk/qcom/Kconfig | 6 +-
> drivers/clk/qcom/gcc-msm8917.c | 617 +++++-
> drivers/pinctrl/qcom/Kconfig.msm | 4 +-
> drivers/pinctrl/qcom/pinctrl-msm8917.c | 8 +-
> include/dt-bindings/clock/qcom,gcc-msm8917.h | 17 +
> 14 files changed, 3277 insertions(+), 17 deletions(-)
> ---
> base-commit: df5d6180169ae06a2eac57e33b077ad6f6252440
> change-id: 20250210-msm8937-228ef0dc3ec9
>
> Best regards,
> --
> Barnabás Czémán <barnabas.czeman@mainlining.org>
>
>

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250211-msm8937-v1-0-7d27ed67f708@mainlining.org:

arch/arm64/boot/dts/qcom/msm8937-xiaomi-land.dtb: gpu@1c00000: clock-names:5: 'alwayson' is not one of ['core', 'iface', 'mem', 'mem_iface', 'alt_mem_iface', 'gfx3d', 'rbbmtimer', 'rbcpr']
from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml#
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dtb: clock-controller@1800000: clocks: [[18], [51], [52, 1], [52, 0]] is too short
from schema $id: http://devicetree.org/schemas/clock/qcom,gcc-msm8917.yaml#
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dtb: clock-controller@1800000: clock-names: ['xo', 'sleep_clk', 'dsi0pll', 'dsi0pllbyte'] is too short
from schema $id: http://devicetree.org/schemas/clock/qcom,gcc-msm8917.yaml#
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dtb: clock-controller@1800000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected)
from schema $id: http://devicetree.org/schemas/clock/qcom,gcc-msm8917.yaml#