From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-aspeed@lists.ozlabs.org, linux-clk@vger.kernel.org
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Dylan Hung <dylan_hung@aspeedtech.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH v2 2/3] clk: aspeed: Add full configs for i3c clocks
Date: Mon, 13 Feb 2023 20:34:14 +0800 [thread overview]
Message-ID: <d58b6170427c9d1414118a0376e98d40f2579b20.camel@codeconstruct.com.au> (raw)
In-Reply-To: <45ce9e62-2620-b959-985d-ae00b071e350@linaro.org>
Hi Krzysztof,
> Bindings are always separate patches.
OK, I'll split these up into the dt-bindings and the clk changes.
> > diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> > index d8b0db2f7a7d..600549d7bee8 100644
> > --- a/include/dt-bindings/clock/ast2600-clock.h
> > +++ b/include/dt-bindings/clock/ast2600-clock.h
> > @@ -57,8 +57,6 @@
> > #define ASPEED_CLK_GATE_I3C3CLK 40
> > #define ASPEED_CLK_GATE_I3C4CLK 41
> > #define ASPEED_CLK_GATE_I3C5CLK 42
> > -#define ASPEED_CLK_GATE_I3C6CLK 43
> > -#define ASPEED_CLK_GATE_I3C7CLK 44
>
> This is an ABI break and commit msg does not really justify it.
I'll add more rationale there.
Cheers,
Jeremy
next prev parent reply other threads:[~2023-02-13 12:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 6:02 [PATCH v2 0/3] Add definitions for AST2600 i3c clocks and resets Jeremy Kerr
2023-02-13 6:02 ` [PATCH v2 1/3] clk: ast2600: allow empty entries in aspeed_g6_gates Jeremy Kerr
2023-02-13 6:02 ` [PATCH v2 2/3] clk: aspeed: Add full configs for i3c clocks Jeremy Kerr
2023-02-13 8:44 ` Krzysztof Kozlowski
2023-02-13 9:48 ` Krzysztof Kozlowski
2023-02-13 12:34 ` Jeremy Kerr [this message]
2023-02-13 6:02 ` [PATCH v2 3/3] dts: ast2600: Add reset config for I3C Jeremy Kerr
2023-02-13 8:44 ` Krzysztof Kozlowski
2023-02-13 9:02 ` Jeremy Kerr
2023-02-13 9:06 ` Krzysztof Kozlowski
2023-02-13 9:23 ` Jeremy Kerr
2023-02-13 9:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58b6170427c9d1414118a0376e98d40f2579b20.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox