Re: [PATCH v8 02/16] clk: Provide new devm_clk helpers for prepared and enabled clocks

Uwe Kleine-König
2022-03-21T07:23:51Z

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

On Sat, Mar 19, 2022 at 06:29:36PM +0000, Jonathan Cameron wrote:
> On Mon, 14 Mar 2022 15:16:29 +0100
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > When a driver keeps a clock prepared (or enabled) during the whole
> > lifetime of the driver, these helpers allow to simplify the drivers.
> >
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Reviewed-by: Alexandru Ardelean <aardelean@deviqon.com>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> One trivial thing below.
>
> > ---
> > drivers/clk/clk-devres.c | 31 ++++++++++++++
> > include/linux/clk.h | 90 +++++++++++++++++++++++++++++++++++++++-
> > 2 files changed, 120 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c
> > index fb7761888b30..4707fe718f0b 100644
> > --- a/drivers/clk/clk-devres.c
> > +++ b/drivers/clk/clk-devres.c
> > @@ -67,12 +67,43 @@ struct clk *devm_clk_get(struct device *dev, const char *id)
> > }
> > EXPORT_SYMBOL(devm_clk_get);
> >
> > +struct clk *devm_clk_get_prepared(struct device *dev, const char *id)
> > +{
> > + return __devm_clk_get(dev, id, clk_get, clk_prepare, clk_unprepare);
>
> Nitpick but this spacing before } in functions is rather unusual and not
> in keeping with the existing code in this file.
>
> > +
> > +}

ack, I fixed that in my tree, so this will be part of an v9. I won't
send it just for this change, though. I fixed three further functions
that had a similar empty line, too.

Thanks for looking
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]