From: 李扬韬 <frank@allwinnertech.com>
To: "Maxime Ripard" <maxime@cerno.tech>
Cc: wens <wens@csie.org>, robh+dt <robh+dt@kernel.org>,
mturquette <mturquette@baylibre.com>, sboyd <sboyd@kernel.org>,
"linus.walleij" <linus.walleij@linaro.org>,
"p.zabel" <p.zabel@pengutronix.de>,
黄烁生 <huangshuosheng@allwinnertech.com>,
"tiny.windzz" <tiny.windzz@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>
Subject: 回复：[PATCH 1/4] clk: sunxi-ng: add support for the Allwinner A100 CCU
Date: Wed, 03 Jun 2020 17:42:28 +0800 [thread overview]
Message-ID: <d7d6ee84-bfbb-4fef-9ed8-1f7045494594.frank@allwinnertech.com> (raw)
In-Reply-To: <20200522151403.7ovbdza2o3cjrb7a@gilmour.lan>
>> + /* Enable the lock bits on all PLLs */
>> + for (i = 0; i < ARRAY_SIZE(pll_regs); i++) {
>> + val = readl(reg + pll_regs[i]);
>> + val |= BIT(29);
>
>Having a define for that would be nice here
>
>> + writel(val, reg + pll_regs[i]);
>> + }
>> +
>> + /*
>> + * In order to pass the EMI certification, the SDM function of
>> + * the peripheral 1 bus is enabled, and the frequency is still
>> + * calculated using the previous division factor.
>> + */
>> + writel(0xd1303333, reg + SUN50I_A100_PLL_PERIPH1_PATTERN0_REG);
>
>Same here
Having a define? I don’t quite understand what you mean,
can you give me an example?
MBR,
Yangtao
next prev parent reply other threads:[~2020-06-03 9:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 3:07 [PATCH 0/4] Allwinner A100 Initial support Frank Lee
2020-05-22 3:07 ` [PATCH 1/4] clk: sunxi-ng: add support for the Allwinner A100 CCU Frank Lee
2020-05-22 15:14 ` Maxime Ripard
2020-06-03 9:42 ` 李扬韬 [this message]
2020-06-03 9:48 ` Chen-Yu Tsai
2020-05-22 3:07 ` [PATCH 2/4] pinctrl: sunxi: add support for the Allwinner A100 pin controller Frank Lee
2020-05-22 15:28 ` Maxime Ripard
2020-06-03 9:44 ` 回复：[PATCH " 李扬韬
2020-06-05 15:13 ` Maxime Ripard
2020-06-16 9:26 ` Frank Lee
2020-06-20 21:27 ` Linus Walleij
2020-05-22 3:07 ` [PATCH 3/4] arm64: allwinner: A100: add the basical Allwinner A100 DTSI file Frank Lee
2020-05-22 3:07 ` [PATCH 4/4] arm64: allwinner: A100: add support for Allwinner Perf1 board Frank Lee
2020-05-22 15:31 ` Maxime Ripard
2020-05-22 15:02 ` [PATCH 0/4] Allwinner A100 Initial support Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d6ee84-bfbb-4fef-9ed8-1f7045494594.frank@allwinnertech.com \
--to=frank@allwinnertech.com \
--cc=devicetree@vger.kernel.org \
--cc=huangshuosheng@allwinnertech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox