Re: [PATCH v3 2/8] clk: qcom: Add support for Video clock controller on SA8775P

Taniya Das
2024-08-16T05:12:40Z

On 7/16/2024 5:35 PM, Konrad Dybcio wrote:
> On 15.07.2024 10:23 AM, Taniya Das wrote:
>> Add support for Video Clock Controller for SA8775P platform.
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
>
> [...]
>
>> +
>> +static struct gdsc video_cc_mvs0_gdsc = {
>> + .gdscr = 0x809c,
>> + .en_rest_wait_val = 0x2,
>> + .en_few_wait_val = 0x2,
>> + .clk_dis_wait_val = 0x6,
>> + .pd = {
>> + .name = "video_cc_mvs0_gdsc",
>> + },
>> + .pwrsts = PWRSTS_OFF_ON,
>> + .parent = &video_cc_mvs0c_gdsc.pd,
>> + .flags = RETAIN_FF_ENABLE | POLL_CFG_GDSCR | HW_CTRL,
>
> HW_CTRL_TRIGGER? Not sure why HW_CTRL wasn't removed altogether with
> the hwctrl patchset..
>
> Konrad

I will submit the next patchset with HW_CTRL_TRIGGER and going forward
as per our Video software team we will support HW_CTRL_TRIGGER for all
targets.

--
Thanks & Regards,
Taniya Das.