From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58DABC433E0 for ; Fri, 10 Jul 2020 09:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33747207DF for ; Fri, 10 Jul 2020 09:00:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="Ii45a4UN"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="oEi3k9/M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgGJJAf (ORCPT ); Fri, 10 Jul 2020 05:00:35 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:43749 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgGJJAf (ORCPT ); Fri, 10 Jul 2020 05:00:35 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 17415C9B; Fri, 10 Jul 2020 05:00:34 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Fri, 10 Jul 2020 05:00:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=qBWL4AtRVUCS4PrimpvMkvUA7sHeyrt hOzfKLQeVpsM=; b=Ii45a4UNgE5tukdKSH0mdZvUmPJEQ7A5PMen8jtuQhM0mBI G8MVxT+q/KDJb1+JI9shtQYlHrXGxcHg9Q0dJy0xc2tzeZWS1Rkyiz6cYQ7HvqgA DPXoyIr4sdHdMC4cuV6hrC1Kk6W1o/6ndUOE637JVSntNjV7uVOyg9brZ534065B Zg0R4knO9pnL0zjatEaNvSKKZ1OOxJScjJzsxatqxs0ccvlgtBAndImHyZmCQpVH vJ/Fp4BCDSVjtm37u0b6fREX6cEYno4zjcw8GWmz6LsmCqPx+o6G/PmM+ocVBw6/ +Ep0qUayer1mjFcZNUEfiQChF7sHVlELyVXVamg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=qBWL4A tRVUCS4PrimpvMkvUA7sHeyrthOzfKLQeVpsM=; b=oEi3k9/MoUzI9/O6aQgtpz XWFUssCB/FnfwlKvndubAxirCZHgy6JiY2NWyi9Ico9F9828yWWcm5NjqssO94jb RSSNsu4n5T9jx4E/eE8dD0dhx2jqTUqDlPSjsnVqh00lbfUX7icqcOkPFfnI82vv 4FZfYnbXk/4UaQv7hAKb0NtItfMQqmdDznKAbyq2XgHjed/j+XDT3A6G382OyY/p UfN0ubhcAl7BlB9Vdvhk2hN/gWVmmtQBrcGjJK0G+h+lx+T9xkYZ3zZQbJWvVTOh KnMtmExF4dgo5NjIiMFr+45IT4jaPrAVU3UJzqNPrDkk57FbtpQo5A+ol7dfEsjw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddugdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1CA19E00C9; Fri, 10 Jul 2020 05:00:32 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-dev0-613-g8a73ad6-fm-20200709.001-g8a73ad6e Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20200709195706.12741-1-eajames@linux.ibm.com> <20200709195706.12741-3-eajames@linux.ibm.com> Date: Fri, 10 Jul 2020 18:30:11 +0930 From: "Andrew Jeffery" To: "Ulf Hansson" , "Eddie James" Cc: linux-clk , "Linux Kernel Mailing List" , linux-aspeed , linux-mmc , "Joel Stanley" , "Adrian Hunter" , "Stephen Boyd" , "Michael Turquette" Subject: Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation Content-Type: text/plain Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Fri, 10 Jul 2020, at 17:09, Ulf Hansson wrote: > On Thu, 9 Jul 2020 at 21:57, Eddie James wrote: > > > > When calculating the clock divider, start dividing at 2 instead of 1. > > The divider is divided by two at the end of the calculation, so starting > > at 1 may result in a divider of 0, which shouldn't happen. > > > > Signed-off-by: Eddie James > > Looks like I can pick this for fixes, as a standalone fix without patch1? No? Yes, please do. Thanks, Andrew