From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Darren Hart <dvhart@infradead.org>,
Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Carlo Caione <carlo@caione.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
linux@endlessm.com, Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH] clk: x86: Do not gate clocks enabled by the firmware
Date: Mon, 24 Jul 2017 16:07:34 +0200 [thread overview]
Message-ID: <d92350f4-8bb3-85cb-4c2b-a44ab794c29a@linux.intel.com> (raw)
In-Reply-To: <1500904960.29303.204.camel@linux.intel.com>
On 7/24/17 4:02 PM, Andy Shevchenko wrote:
> On Mon, 2017-07-24 at 15:49 +0200, Pierre-Louis Bossart wrote:
>> On 7/11/17 1:54 AM, Darren Hart wrote:
>>> On Tue, Jul 11, 2017 at 12:31:28AM +0200, Enric Balletbo Serra
>>> wrote:
>
>>>> Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>>
>>> Excellent, thank you Enric. Pierre, any objections to this going in
>>> to
>>> 4.13 now and stable back to 4.12?
>>
>> I saw an update of this patch being merged while I was away on an
>> extended summer break, but out of curiosity what was the problem with
>> no
>> audio on Baytrail? the code was added precisely to add support for
>> 19.2
>> MHz on Baytrail and finally solve audio issues. I have no reports of
>> broken functionality with this 282a4e4 commit... Enric, do you have a
>> bugzilla or pointers?
>
> TL;DR: We should respect firmware settings before blindly shut down
> "unused" resources. (We used to have similar stuff in GPIO/pinctrl
> driver for direct IRQ pins, where we shut up the pins which are used
> directly by IOAPIC)
I wasn't arguing against those patches, just curious as to which
platforms were broken by setting pmc_plat_3 blindly in the driver.
next prev parent reply other threads:[~2017-07-24 14:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 20:38 [PATCH] clk: x86: Do not gate clocks enabled by the firmware Carlo Caione
2017-07-10 22:31 ` Enric Balletbo Serra
2017-07-10 23:54 ` Darren Hart
2017-07-11 1:29 ` Stephen Boyd
2017-07-11 1:38 ` Darren Hart
2017-07-11 8:09 ` Carlo Caione
2017-07-24 13:49 ` Pierre-Louis Bossart
2017-07-24 14:02 ` Andy Shevchenko
2017-07-24 14:07 ` Pierre-Louis Bossart [this message]
2017-07-24 15:02 ` Enric Balletbo Serra
2017-07-24 16:26 ` Pierre-Louis Bossart
2017-07-24 16:33 ` Enric Balletbo Serra
2017-07-24 16:44 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d92350f4-8bb3-85cb-4c2b-a44ab794c29a@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=carlo@caione.org \
--cc=carlo@endlessm.com \
--cc=dvhart@infradead.org \
--cc=eballetbo@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox