From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/8] arm64: dts: qcom: sa8295p-adp: Enable GPU
Date: Sat, 30 Dec 2023 13:22:10 +0100 [thread overview]
Message-ID: <dc11577e-7088-4975-8543-ad8001e678fe@linaro.org> (raw)
In-Reply-To: <20231227202130.GA1315173@hu-bjorande-lv.qualcomm.com>
On 27.12.2023 21:21, Bjorn Andersson wrote:
> On Wed, Dec 27, 2023 at 02:09:47AM +0100, Konrad Dybcio wrote:
>> On 22.12.2023 05:39, Bjorn Andersson wrote:
>>> With the necessary support in place for supplying VDD_GFX from the
>>> MAX20411 regulator, enable the GPU clock controller, GMU, Adreno SMMU
>>> and the GPU on the SA8295P ADP.
>>>
>>> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
>>> ---
>> [...]
>>
>>> +&gpucc {
>>> + vdd-gfx-supply = <&vdd_gfx>;
>>> + status = "okay";
>>> +};
>> Already enabled
>>
>
> No, we're disabling these in sa8540p.dtsi, so they need to be re-enabled
> here.
>
> I don't remember if it's because the attempt to bring up gfx.lvl or if
> it's the attempt to operate the GPU components without adequate VDD_GFX,
> that is causing the issue...but either way, we don't survive boot.
Oh right!
On 8155 touching mmcx, lcx or lmx would kaboom the platform..
>
>
> It's possible that we could move the max20411 up to sa8540p.dtsi to
> avoid the intermediate disable, but I'm not confident that it's "part of
> the platform"...
Yeah, it's probably a question that is impossible to answer, as my
wild assumption is that all designs are ADP-derived anyway..
Konrad
next prev parent reply other threads:[~2023-12-30 12:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 4:39 [PATCH v2 0/8] arm64: dts: qcom: sa8295p: Enable GPU Bjorn Andersson
2023-12-22 4:39 ` [PATCH v2 1/8] dt-bindings: clock: qcom: Allow VDD_GFX supply to GX Bjorn Andersson
2023-12-22 8:12 ` Krzysztof Kozlowski
2023-12-22 12:07 ` Konrad Dybcio
2023-12-27 20:30 ` Bjorn Andersson
2023-12-29 23:51 ` Konrad Dybcio
2023-12-22 4:39 ` [PATCH v2 2/8] clk: qcom: gdsc: Enable supply reglator in GPU GX handler Bjorn Andersson
2023-12-27 1:07 ` Konrad Dybcio
2023-12-22 4:39 ` [PATCH v2 3/8] clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc Bjorn Andersson
2023-12-27 1:07 ` Konrad Dybcio
2024-01-08 18:23 ` Bjorn Andersson
2023-12-22 4:39 ` [PATCH v2 4/8] soc: qcom: rpmhpd: Drop SA8540P gfx.lvl Bjorn Andersson
2023-12-27 1:08 ` Konrad Dybcio
2024-01-03 12:54 ` Ulf Hansson
2023-12-22 4:39 ` [PATCH v2 5/8] arm64: dts: qcom: sa8540p: Drop gfx.lvl as power-domain for gpucc Bjorn Andersson
2023-12-27 1:10 ` Konrad Dybcio
2023-12-22 4:39 ` [PATCH v2 6/8] arm64: dts: qcom: sa8295p-adp: add max20411 Bjorn Andersson
2023-12-27 1:08 ` Konrad Dybcio
2023-12-22 4:39 ` [PATCH v2 7/8] arm64: dts: qcom: sa8295p-adp: Enable GPU Bjorn Andersson
2023-12-22 6:31 ` Dmitry Baryshkov
2023-12-27 1:09 ` Konrad Dybcio
2023-12-27 20:21 ` Bjorn Andersson
2023-12-30 12:22 ` Konrad Dybcio [this message]
2023-12-22 4:39 ` [PATCH v2 8/8] arm64: defconfig: Enable MAX20411 regulator driver Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc11577e-7088-4975-8543-ad8001e678fe@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox