From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F096C433F5 for ; Thu, 21 Apr 2022 09:07:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387321AbiDUJKo (ORCPT ); Thu, 21 Apr 2022 05:10:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387317AbiDUJKm (ORCPT ); Thu, 21 Apr 2022 05:10:42 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CF7313F80; Thu, 21 Apr 2022 02:07:53 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id AED2A1F45275 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1650532072; bh=YhirVsiU72VmlViC0qF9dJVu+SZvUIko/Y4uOCGf3MI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AYLSWEI419fRBsa/VH6DZe33qRGRWn+AvtYeJmCTbyhRxr7uRbmfEpoOKftWN7RYN BeyJmuzVrRfedyxDyZ5R89L6PJh6Pp0x/lxraEqvz/kvlCfU1F3kcUiWCAX4g0Y54e hEG3EMstHWlXTu30rwEO5Bi2IGI7w6g+bhi1UJ+xTD3JGNDmqgdTIn1RbCm+jkUcXJ wptat8V+y4M7tnFn8g3t+pQFoaQOIie0b96DbhP8VSdnmCZ6LS6+KxnttmUfE7zmhn OKJqNQxVSM6maCH3/Sf0KRP5zb7rilWYixPLnCsbF4vb5qlLPZiMsJAJ7yCiw+EAzD 0EQ622FZGi8fw== Message-ID: Date: Thu, 21 Apr 2022 11:07:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH V2 07/12] clk: mediatek: reset: Add return for clock reset register function Content-Language: en-US To: Rex-BC Chen , mturquette@baylibre.com, sboyd@kernel.org Cc: matthias.bgg@gmail.com, p.zabel@pengutronix.de, chun-jie.chen@mediatek.com, wenst@chromium.org, runyang.chen@mediatek.com, linux-kernel@vger.kernel.org, allen-kh.cheng@mediatek.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220420130527.23200-1-rex-bc.chen@mediatek.com> <20220420130527.23200-8-rex-bc.chen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220420130527.23200-8-rex-bc.chen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Il 20/04/22 15:05, Rex-BC Chen ha scritto: > To make error handling, we add return for mtk_clk_register_rst_ctrl(). > > Signed-off-by: Rex-BC Chen > --- > drivers/clk/mediatek/reset.c | 14 ++++++++------ > drivers/clk/mediatek/reset.h | 4 ++-- > 2 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c > index d67c13958458..b164b1da7dd3 100644 > --- a/drivers/clk/mediatek/reset.c > +++ b/drivers/clk/mediatek/reset.c ..snip.. > @@ -103,6 +103,8 @@ void mtk_clk_register_rst_ctrl(struct device_node *np, > pr_err("could not register reset controller: %d\n", ret); > kfree(data); If you return for all error conditions, you can return 0 at the end, so here: return ret; > } > + > + return ret; and here: return 0; > } > > MODULE_LICENSE("GPL"); Cheers, Angelo