From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7162BC61CE4 for ; Sat, 19 Jan 2019 07:59:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35DC12084C for ; Sat, 19 Jan 2019 07:59:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="rrEDuSRM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727554AbfASH7P (ORCPT ); Sat, 19 Jan 2019 02:59:15 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:57880 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727496AbfASH7P (ORCPT ); Sat, 19 Jan 2019 02:59:15 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x0J7wiOE112043; Sat, 19 Jan 2019 01:58:44 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1547884725; bh=LaTfXonYC8XqGiw8fmtntq9KflmaFB/2JxWLRHfXkl8=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=rrEDuSRMm5vKbCPu5H3QhUnT/zeI0iiUoTnTzXpACFcIuh27IvQNH9t/Ho8/9IP0L D5zAB34GxIQdAUZnQOhoMmN+tZRi4XPbKJyME0TFDpHZliU5z/OhZ0+naQRxE+mgUE NeVflERGElylnSnbERxM/NwVHazco0CkKQCZ31jY= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x0J7wisZ079451 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 19 Jan 2019 01:58:44 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Sat, 19 Jan 2019 01:58:44 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Sat, 19 Jan 2019 01:58:44 -0600 Received: from [172.22.216.68] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x0J7wdAv027019; Sat, 19 Jan 2019 01:58:40 -0600 Subject: Re: [Letux-kernel] [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that To: Andreas Kemnade CC: Tony Lindgren , Discussions about the Letux Kernel , , , , , , , , References: <20190116220429.9136-1-andreas@kemnade.info> <20190116220429.9136-4-andreas@kemnade.info> <20190118154807.GV5544@atomide.com> <20190118181827.7163bee4@aktux> <20190118183630.GX5544@atomide.com> <20190118203832.3be7975e@aktux> <20190118204204.44db353f@aktux> <20190118194802.GZ5544@atomide.com> <20190119081211.73844b6a@aktux> From: "J, KEERTHY" Message-ID: Date: Sat, 19 Jan 2019 13:28:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190119081211.73844b6a@aktux> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 1/19/2019 12:42 PM, Andreas Kemnade wrote: > On Sat, 19 Jan 2019 12:09:48 +0530 > "J, KEERTHY" wrote: > >> On 1/19/2019 1:18 AM, Tony Lindgren wrote: >>> * Andreas Kemnade [190118 19:42]: >>>> On Fri, 18 Jan 2019 20:38:47 +0100 >>>> Andreas Kemnade wrote: >>>> >>>>> Hi, >>>>> >>>>> On Fri, 18 Jan 2019 10:36:30 -0800 >>>>> Tony Lindgren wrote: >>>>> >>>>> [...] >>>>>> til the next workaround. >>>>>> >>>>>>> That flags also causes the iclk being enabled/disabled >>>>>>> manually. >>>>>> >>>>>> Yes but SWSUP_IDLE for the interface clock to me currently >>>>>> just means: >>>>>> >>>>>> "manually enable and disable ocp interface clock" >>>>>> >>>>> well, if we want to manually disable it and not automatically, >>>>> we have to disable autoidle or it will be automatically disabled. >>>>> >>>>> Disabling it manually when it is already auto-disabled (by autoidle) is >>>>> just practically a no-op towards the clock. >>>>> >>>>>> and with your changes it becomes: >>>>>> >>>>>> "manually enable and disable ocp interface clock and block >>>>>> autoidle while in use". >>>>>> >>>>>> So aren't we now changing the way things behave in general >>>>>> for SWSUP_IDLE? >>>>>> >>>>> Yes, we are, so proper testing is needed. But If I read those comments >>>>> it was always intended this way but not fully implemented because it >>>>> appeared to be more work like needing a usecounter (which my patchset >>>>> also adds) for that autoidle flag. >>>>> >>>> and there are quite few hwmods marked by this flag. >>>> And then there are those clocks marked by this flags (on am33xx) which >>>> do not have that autoidle feature at all, so the risk is not too high. >>> >>> Keerthy, can you please test this series on top of the >>> related clock patches with your am335x PM test cases? >> >> Can you point me to the clock series that needs to be tested >> along with this? >> > > https://patchwork.kernel.org/project/linux-clk/list/?series=66691 Thanks Andreas. I will test both series and get back. > > Regards, > Andreas >