From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6604F20A5E1 for ; Thu, 24 Apr 2025 11:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745492478; cv=none; b=rOWjO0ePrvFNSqcgTj8J831PiivuMPlTELANUKJgpUJqIQmzVYAiVDuMpEh4XJPTyUdPU7PsW4qce7u19k0hX3C9hcr+kSfRXhYFfNE/UGMv9c3KYSO1w3zhsPZtJs0M7qNmxhYLqZkgiGf2y4+jaaWWKRwwCdp8xvzcrQJ+pHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745492478; c=relaxed/simple; bh=LRMvNGED8g7QH78pxs4OzLmg43eZZ9iT6bQtOLqONp8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ecieMMuCsifNfxQ/Rxu1nxMCyydJ/QxcGQTexdgxq6vXjgAzicKFqHd6aW55MNXV4J9c0G0dcdRXsiInDufXHAY2DrHNOZjgQdkSEemTLFYGsvJthMe5owkIhr0pPbxR7wJnA2w9jMRyjzXnKvZJ0sEQ936b4Ksi3/IiddfeuJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HmvryqqV; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HmvryqqV" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-549c70bf6caso114685e87.0 for ; Thu, 24 Apr 2025 04:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745492474; x=1746097274; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fKAiZ5oUfGoNvPn02SKW2hKz0+x21UCr7tagt17mZ3E=; b=HmvryqqVVf3TYIVGVXKlQlmDc0v+lplFNO9sND0sEhlOCpZZeWPtJARdHHkDsKI6ns X/9mBE9CdRWK5j/QlddQXDRa76fnj0rbdVjznxolmVdV6gC0nrWauyJzVmqyEU5W+5AE 1SNOSxKyZ783GshHzBWnbEeCdPlcBVbTPRO6chz3JOxiyhnGB9gOR2AnLnX6RFsl983Z dtLZG03k+LgId1WHEtx12CoZJPbQKOPRmBZYlwGg4Q3rh3HHx/SVIo+nsCvU57goOMFB 1Knp15b/UVfq0hR37/q+pyR5meduAb+aMWyvpXCR47ocXssdfe/B90WyzD7zzIt6lL69 DZIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745492474; x=1746097274; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fKAiZ5oUfGoNvPn02SKW2hKz0+x21UCr7tagt17mZ3E=; b=oy9zpyjf7pUk+y1CeJPWXRYTJEHnwG6oj2OhEGAT7+P4z9llCK4UVIuAEuEbXNcQ8z 2j2GGNZHtfWTy75OTm7J5/EGkEYkT90Nvu/lPNiyx6ok1Dp83vlv0YspGRXSoNlkjn9z U7qsnV+FIr0bt/Xp8sj7tp+QHdj/BEJ47FLbgOzyNKGA4KE18+rblVT//c4TPd+P90K2 eYaIdCDnOtsOnjboUGqvh7wp3C97K7+MVlhqiva+dcx/f0ig+vQ0IUDKhkg4LZ2Hufvw lNduFhVDnQ6EkNG/7dTgZBAtldeRQAT0v+iduJmYz4Us68Ai3v5ZolMqPQujaqqEnS8g bvMQ== X-Forwarded-Encrypted: i=1; AJvYcCVbEpov5M/VimvlxlabCaAYK0u/V2hbMrHrdc1DWaTgIN+SZMLnxI711/AaVxCRpCTZpEdlXSLTD8A=@vger.kernel.org X-Gm-Message-State: AOJu0Yxfa/HsmxXzbOD4B4sZDw0/WtP41TafNUXhhLEHSEtIjUj3Hfd5 j7h0ksi32KbAAZBBtO9En7PQBdQPEpSdvh/tEpd4RiGUWw2ZzGug/MeeGz7lUGiGEwAa91eIlHW s X-Gm-Gg: ASbGncvWGeiCzzwZ6cer0S+gCv0v09dRKwfAqTYNSRf3Q/QxiLQAUNHg2P1PZ3FoLvy DAJFwOIwq2HRaKKP7JQC7Q3l8hijsRC33Ht6M6Mi8pSqXJyqIqwJXETWfFEhTKDbJwEfbxWAovK h6qB2Ey4nMyyLHJrDfW4akSNyes+h4DgxyL/GxqSCHodpI4YA9n7zeBI9vjWATxSTQx1XRkXj9m VyZ/oIPj+hlKCQuSC42Zk41GB/iiUpKvuAYQDgaQbaMr7xzD+kLICSQ5W4+pVEXerKVWLSqwTBg wjyVwEUbDHBHW7zGa7bQol+VUoaWnvMXogc6MLzUdiIsr1DuaDjpMjveMBf5UUdEL3+KfxkWkcb lIVT/0TTzMK1NC2vj+kk= X-Google-Smtp-Source: AGHT+IGgDVI0PyQ95vORTGKJqjnW2hj2x8uhHnF4g9z7xQDBS5ScvdRcsn0yFlNT9J59RjGOp2CMCg== X-Received: by 2002:a05:6512:3f1a:b0:549:5769:6ae8 with SMTP id 2adb3069b0e04-54e7c413dfdmr276608e87.1.1745492474321; Thu, 24 Apr 2025 04:01:14 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54e7ccb88d1sm198436e87.252.2025.04.24.04.01.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 04:01:13 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 14:01:12 +0300 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/5] dt-bindings: media: Add qcom,x1e80100-camss Content-Language: ru-RU To: Krzysztof Kozlowski , Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20250314-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v6-0-edcb2cfc3122@linaro.org> <20250314-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v6-2-edcb2cfc3122@linaro.org> <3ec3fd62-bf21-47e7-873c-ce151589d743@linaro.org> <54eeb470-cd90-4bc2-b415-6dea1ce2321d@linaro.org> <0ab31397-580f-4e5a-b9ad-d9bf79d29106@linaro.org> <36feffed-4558-4e59-97db-2f0e916dbfc7@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <36feffed-4558-4e59-97db-2f0e916dbfc7@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/24/25 13:17, Bryan O'Donoghue wrote: > On 24/04/2025 11:07, Krzysztof Kozlowski wrote: >> On 24/04/2025 11:34, Bryan O'Donoghue wrote: >>> On 24/04/2025 07:40, Krzysztof Kozlowski wrote: >>>>> + vdd-csiphy-0p8-supply: >>>> Same comment as other series on the lists - this is wrong name. There >>>> are no pins named like this and all existing bindings use different name. >>> >>> The existing bindings are unfortunately not granular enough. >>> >>> I'll post s series to capture pin-names per the SoC pinout shortly. >> How are the pins/supplies actually called? >> >> Best regards, >> Krzysztof > > I don't think strictly algning to pin-names is what we want. > > Here are the input pins > > VDD_A_CSI_0_1_1P2 > VDD_A_CSI_2_4_1P2 > VDD_A_CSI_0_1_0P9 > VDD_A_CSI_2_4_0P9 > > I think the right way to represent this > > yaml: > csiphy0-1p2-supply > csiphy1-1p2-supply > csiphy2-1p2-supply > csiphy3-1p2-supply > > dts: > > vdd-csiphy0-0p9-supply = <&vreg_l2c_0p8>; > vdd-csiphy1-0p9-supply = <&vreg_l2c_0p8>; > > etc > > vdda-csiphy0-1p2-supply = <&vreg_l1c_1p2>; > > because that captures the fact we could have separate lines for each > phy, names it generically and then leaves it up to the dts > implementation to represent what actually happened on the PCB. > > That would also work for qcm2290 and sm8650. > > https://lore.kernel.org/linux-arm-msm/20250423221954.1926453-2-vladimir.zapolskiy@linaro.org/ > > So for sm8650 instead of > > + vdda-csi01-0p9-supply: > + > + vdda-csi24-0p9-supply: > + > + vdda-csi35-0p9-supply: > + > + vdda-csi01-1p2-supply: > + > + vdda-csi24-1p2-supply: > + > + vdda-csi35-1p2-supply: > > you would have > > + vdda-csiphy0-0p9-supply: > + > + vdda-csiphy1-0p9-supply: > > + vdda-csiphy0-1p2-supply: > + > + vdda-csiphy1-1p2-supply: > This option will work for SM8650, if the list of the given 6 supplies, where one supply property represens a pad to power up two CSIPHYs, is extended to the list of 12 supplies, one for each individual CSIPHY. Both options will be technically equivalent/correct, an alternative one is just two times longer. I would appreciate to get a maintainer's decision here. -- Best wishes, Vladimir