From: Marek Vasut <marex@denx.de>
To: Liu Ying <victor.liu@nxp.com>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com,
will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com,
mturquette@baylibre.com, sboyd@kernel.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
quic_bjorande@quicinc.com, geert+renesas@glider.be,
dmitry.baryshkov@linaro.org, arnd@arndb.de,
nfraprado@collabora.com
Subject: Re: [PATCH v7 2/7] Revert "clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate"
Date: Fri, 15 Nov 2024 13:31:28 +0100 [thread overview]
Message-ID: <df6ebdde-65f8-4aad-93c7-b1df695bd2ef@denx.de> (raw)
In-Reply-To: <20241114065759.3341908-3-victor.liu@nxp.com>
On 11/14/24 7:57 AM, Liu Ying wrote:
> This reverts commit ff06ea04e4cf3ba2f025024776e83bfbdfa05155.
>
> media_disp1_pix clock is the pixel clock of the first i.MX8MP LCDIFv3
> display controller, while media_disp2_pix clock is the pixel clock of
> the second i.MX8MP LCDIFv3 display controller. The two display
> controllers connect with Samsung MIPI DSI controller and LVDS Display
> Bridge(LDB) respectively. Since the two display controllers are driven
> by separate DRM driver instances and the two pixel clocks may be derived
> from the same video_pll1_out clock(sys_pll3_out clock could be already
> used to derive audio_axi clock), there is no way to negotiate a dynamically
> changeable video_pll1_out clock rate to satisfy both of the two display
> controllers. In this case, the only solution to drive them with the
> single video_pll1_out clock is to assign a sensible/unchangeable clock
> rate for video_pll1_out clock. Thus, there is no need to set the
> CLK_SET_RATE_PARENT flag for media_disp{1,2}_pix clocks, drop it then.
>
> Fixes: ff06ea04e4cf ("clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
Uh, I almost missed this revert between all the LDB patches.
This revert will break my usecase on MX8MP where I need to operate two
disparate panels attached to LVDS and TC358767 DSI-to-DP bridge and I
need accurate pixel clock for both. Not being able to configure accurate
pixel clock will make the displays not work, so from my side, this is a
NAK, sorry.
There has to be some better solution which still allows the PLL
reconfiguration to achieve accurate pixel clock.
next prev parent reply other threads:[~2024-11-15 13:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 6:57 [PATCH v7 0/7] Add ITE IT6263 LVDS to HDMI converter support Liu Ying
2024-11-14 6:57 ` [PATCH v7 1/7] arm64: dts: imx8mp-skov-revb-mi1010ait-1cp1: Set "media_disp2_pix" clock rate to 70MHz Liu Ying
2024-11-14 6:57 ` [PATCH v7 2/7] Revert "clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate" Liu Ying
2024-11-15 10:19 ` Peng Fan
2024-11-15 12:31 ` Marek Vasut [this message]
2024-11-18 3:54 ` Ying Liu
2024-11-19 1:13 ` Marek Vasut
2024-11-19 8:18 ` Ying Liu
2024-11-19 21:42 ` Marek Vasut
2024-11-20 6:38 ` Ying Liu
2024-11-21 2:45 ` Marek Vasut
2024-11-22 3:39 ` Ying Liu
2024-11-23 19:47 ` Adam Ford
2024-11-23 20:11 ` Marek Vasut
2024-11-14 6:57 ` [PATCH v7 3/7] drm/bridge: fsl-ldb: Get the next non-panel bridge Liu Ying
2024-11-14 6:57 ` [PATCH v7 4/7] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "ldb" clock rate Liu Ying
2024-11-14 6:57 ` [PATCH v7 5/7] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "pix" " Liu Ying
2024-11-14 6:57 ` [PATCH v7 6/7] arm64: dts: imx8mp-evk: Add NXP LVDS to HDMI adapter cards Liu Ying
2024-11-14 6:57 ` [PATCH v7 7/7] arm64: defconfig: Enable ITE IT6263 driver Liu Ying
2024-12-17 14:07 ` [PATCH v7 0/7] Add ITE IT6263 LVDS to HDMI converter support Maxime Ripard
2024-12-18 6:02 ` Liu Ying
2025-01-28 9:21 ` Maxime Ripard
2025-02-07 7:44 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df6ebdde-65f8-4aad-93c7-b1df695bd2ef@denx.de \
--to=marex@denx.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=abelvesa@kernel.org \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=peng.fan@nxp.com \
--cc=quic_bjorande@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox