From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0741DA10F; Wed, 4 Sep 2024 13:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725456414; cv=none; b=kZCEUeUrp5aJK1jJZOzhqtxeHEVCa66Y3F8QAUZNRHgOX1ccOS68KK4jYVa5DOENgvkj+NEH8r7K03iGB4Ht+0HKEepzTw4Itp6fmXVG/PwhWP/115UMFbxm7baZqBWt7IEQ4EeWZsCo9f0vEdKjO6DZ+WdfMmjxIiM3NqNImsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725456414; c=relaxed/simple; bh=X3RwhSnOPI7B3SUDwwNDjphzki+yiClyRlfzwMUfMQ0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=QFsYvh8TC/RdOgoPwQ6QgZn31ijLvPhST6+C868tJ4Cr90LgpujtDOx+6z1LOFDpi5XQPJVP37SIe5UAvYl9c9FntHEsqG/FxBRN48F5u3pvq8jOxlJvXeykvaPr9qnBIJ0hquiv6x2tG2jb4LmXSicYV8vkN3EZTmhTYx6bT3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=apzxV/JX; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="apzxV/JX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1725456411; x=1756992411; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=X3RwhSnOPI7B3SUDwwNDjphzki+yiClyRlfzwMUfMQ0=; b=apzxV/JXBheW0Z46dX4EgKXtPmn8fZzaPyFYHGzvnXhIEsuDBHZ8g1Qd LgMt4Cjmp4AVIbn5Ga6FD/OOQJaoAMpjcbWoga3gBP7T1zc/vma9JLoES gc8hkcr+Q5VqGgLfFVI4Cmx39m39Q67+eCc1TcXJlGVILCT3HTkAw07yF i3MtFighsakBU3LCWlvrRajeJjo7ACKjgFivI5fBElnjbPfHezN0mM/Iw O0gEdy3VfGV59LvobF+bsqO4fk524AhNsbD/glAoDEWRmxWTyzoTK4QLL h5tyH60ieAifHTkTM8wKC7rXCBmaSbTJ/trxUzR8iQ6B4kcxw5EE9wDHH A==; X-CSE-ConnectionGUID: JRh8fRxbQ+6YUqmruMXFWw== X-CSE-MsgGUID: VrJ1OOsKTfGljRdVl8vSqQ== X-IronPort-AV: E=Sophos;i="6.10,202,1719903600"; d="scan'208";a="34388770" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Sep 2024 06:26:50 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 4 Sep 2024 06:26:26 -0700 Received: from [10.180.116.161] (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Wed, 4 Sep 2024 06:26:25 -0700 Message-ID: Date: Wed, 4 Sep 2024 15:26:45 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: get, prepare, enable a clock not in DT? Content-Language: en-US, fr-FR To: claudiu beznea , , , References: <20240816-ludicrous-lagging-65e750c57ab4@thorsis.com> <384919bc-7d45-445a-bc85-630c599d43ef@tuxon.dev> <20240820-grandpa-down-fec4231f971c@thorsis.com> <20240828-gainfully-cringing-2f420d8882bd@thorsis.com> <6cd18742-7ba8-4b0c-aff9-7065bccd4095@tuxon.dev> <20240902-machinist-straggler-cce44ffa4a7c@thorsis.com> <6bc72d8a-c7b8-40de-b4c2-0170dde36d33@tuxon.dev> From: Nicolas Ferre Organization: microchip In-Reply-To: <6bc72d8a-c7b8-40de-b4c2-0170dde36d33@tuxon.dev> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 04/09/2024 at 09:33, claudiu beznea wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi, Alexander, > > On 02.09.2024 11:24, Alexander Dahl wrote: >> Hello Claudiu, >> >> Am Sat, Aug 31, 2024 at 06:49:59PM +0300 schrieb claudiu beznea: >>> Hi, Alexander, >>> >>> On 28.08.2024 09:55, Alexander Dahl wrote: >>>> Hello Claudiu, >>>> >>>> Am Fri, Aug 23, 2024 at 05:29:44PM +0300 schrieb claudiu beznea: >>>>> >>>>> >>>>> On 20.08.2024 15:17, Alexander Dahl wrote: >>>>>> By chance: I don't have a sama7g5 based board at hand for testing. >>>>>> The datasheet says the same as for sam9x60. >>>>>> Does the nvmem_microchip_otpc driver actually work without timeout on >>>>>> sama7g5? >>>>> >>>>> Yes! This should be because system bus is clocked from MCK0 (as mentioned >>>>> in peripheral identifiers table) which is enabled by bootloader. >>>> >>>> Not sure I can follow. Citing the SAMA7G5 datasheet section 30.4 >>>> (OTPC Product Dependencies): >>>> >>>> "The OTPC is clocked through the Power Management Controller >>>> (PMC). The user must power on the main RC oscillator and enable >>>> the peripheral clock of the OTPC prior to reading or writing the >>>> OTP memory." >>> >>> I don't see this in [1]. Only: >>> >>> "The OTPC is clocked through the Power Management Controller (PMC), so the >>> programmer must first to configure the PMC." >>> >>> From this I got that it is about the MCK0 listed in table Table 8-11. >>> Peripheral Identifiers. >>> >>> [1] >>> https://ww1.microchip.com/downloads/aemDocuments/documents/MPU32/ProductDocuments/DataSheets/SAMA7G5-Series-Data-Sheet-DS60001765A.pdf >> >> Well, this seems to be an older version revision A from 03/2022. >> I have DS60001765B (revision B) from 12/2023 and got this here (note >> the missing 'A' in the filename): >> >> https://ww1.microchip.com/downloads/aemDocuments/documents/MPU32/ProductDocuments/DataSheets/SAMA7G5-Series-Data-Sheet-DS60001765.pdf > > This version clearly express your findings. The unknown now is the > "peripheral clock" that need to be enabled along with the > main_rc_oscillator. For that you may want to play around with PMC > Peripheral Control Register, PMC peripheral clock status register and see > if OTPC fails to work when disabling the peripheral clock with the OTPC ID > as there is no information about peripheral clock for OTPC in the > peripheral identifers table. > > Hope this helps. FYI, I asked internally. I'll keep you posted. Regards, Nicolas >> Linked here: >> >> https://www.microchip.com/en-us/product/sama7g54 >> >> The revision history is not very specific, it only says "Updated Power >> Management". Errata sheet has nothing interesting on that topic. >> >> We both cited what we saw in the datasheets. Revision A has the >> section you cited, revision B has the section I cited. >> >>>> Table from section 8.5 (Peripheral Clocks …) has no check mark at "PMC >>>> clock control" but indeed lists MCK0 as main system bus clock. >>> >>> This is what I was taking about. >>> >>>> If it >>>> works on SAMA7G5 without explicitly enabling main RC oscillator, then >>>> either that clock is on accidentally, or the datasheet is wrong in the >>>> OTPC section. >>> >>> Might be. >> >> I don't have a SAMA7G5 at hand. Someone who has could test if OTPC >> works with/without MCK0, and with/without main RC osc, all possible >> combinations would be most helpful: with none of those, with only one, >> only the other, both. >> >> Hope we get this clock stuff sorted out?! >> >> Greets >> Alex >> >>> >>> Thank you, >>> Claudiu Beznea >>> >>>> >>>> Personally I find the "clocked through PMC" part in the OTPC >>>> section suspicious, because in the peripheral identifiers table OTPC >>>> has no "PMC Clock Control" mark. >>>> >>>> Not sure what's the difference between SAM9X60 and SAMA7G5 internally, >>>> though. From a user's POV it's possible one of them requires the >>>> main RC osc, and the other does not, but currently you can't tell from >>>> the datasheets. >>>> >>>>> Here is a snapshot of reading the NVMEM on a SAMA7G5 with bootconfig and >>>>> thermal calibration packets: >>>>> https://www.linux4sam.org/bin/view/Linux4SAM/ThermalFaq >>>> >>>> Greets >>>> Alex >>>> >>>