Re: [PATCH 20/32] riscv: Add Kendryte K210 FPIOA pinctrl driver

kernel test robot
2020-11-09T18:49:02Z

[-- Attachment #1: Type: text/plain, Size: 2785 bytes --]

Hi Damien,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on spi/for-next pza/reset/next linus/master v5.10-rc3 next-20201109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Damien-Le-Moal/RISC-V-Kendryte-K210-support-improvments/20201109-095540
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: riscv-nommu_k210_defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b53c7c4d3b5b4658b4951955fd69c0ceb4bfac4d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Damien-Le-Moal/RISC-V-Kendryte-K210-support-improvments/20201109-095540
git checkout b53c7c4d3b5b4658b4951955fd69c0ceb4bfac4d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/pinctrl-k210.c:848:5: warning: no previous prototype for 'k210_pinctrl_dt_node_to_map' [-Wmissing-prototypes]
848 | int k210_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/k210_pinctrl_dt_node_to_map +848 drivers/pinctrl/pinctrl-k210.c

847
> 848 int k210_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
849 struct device_node *np_config,
850 struct pinctrl_map **map, unsigned int *num_maps)
851 {
852 unsigned int reserved_maps;
853 struct device_node *np;
854 int ret;
855
856 reserved_maps = 0;
857 *map = NULL;
858 *num_maps = 0;
859
860 ret = k210_pinctrl_dt_subnode_to_map(pctldev, np_config, map,
861 &reserved_maps, num_maps);
862 if (ret < 0)
863 goto err;
864
865 for_each_available_child_of_node(np_config, np) {
866 ret = k210_pinctrl_dt_subnode_to_map(pctldev, np, map,
867 &reserved_maps, num_maps);
868 if (ret < 0)
869 goto err;
870 }
871 return 0;
872
873 err:
874 pinctrl_utils_free_map(pctldev, *map, *num_maps);
875 return ret;
876 }
877

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 9115 bytes --]