From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de ([217.72.192.78]:55096 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbcIPGBQ (ORCPT ); Fri, 16 Sep 2016 02:01:16 -0400 Subject: Re: clk/Renesas-MSTP: Rename jump labels in cpg_mstp_attach_dev() To: Geert Uytterhoeven References: <566ABCD9.1060404@users.sourceforge.net> <1575ddf1-bd1a-fe98-046a-a586eb30fe47@users.sourceforge.net> Cc: linux-clk@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart , Michael Turquette , Simon Horman , Stephen Boyd , Ulf Hansson , LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall , linux-doc@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Fri, 16 Sep 2016 08:00:43 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Sender: linux-clk-owner@vger.kernel.org List-ID: > "Choose label names which say what the goto does or why the goto exists." > > I prefer the "why" over the "what". Does your opinion indicate also that you would appreciate another adjustment around the quoted sentence from "Chapter 7: Centralized exiting of functions" of the document "CodingStyle"? Would you like to achieve that the potential for confusion will be reduced a bit more there? > And the "indent labels with a single space" rule will be removed soon, I am unsure on how this "story" will evolve further. Will the indentation rules become any more precise for Linux source code? > as there's no longer a technical reason for it after > https://lkml.org/lkml/2016/9/7/316 The software update "Set git diff driver for C source code files" is also interesting for current versions. Will language-specific rules which are supported by recent Git software influence any capabilities for the command "diff --show-c-function"? Regards, Markus