From: Stephen Boyd <sboyd@kernel.org>
To: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Edward-JW Yang" <edward-jw.yang@mediatek.com>,
"Johnson Wang" <johnson.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: kernel@collabora.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: Re: [PATCH] clk: mediatek: pllfh: Don't log error for missing fhctl node
Date: Wed, 10 Apr 2024 20:49:48 -0700 [thread overview]
Message-ID: <e6ecf39d6b4378731f3aa19350e0d5b7.sboyd@kernel.org> (raw)
In-Reply-To: <20240308-mtk-fhctl-no-node-error-v1-1-51e446eb149a@collabora.com>
Quoting Nícolas F. R. A. Prado (2024-03-08 12:29:56)
> Support for fhctl clocks in apmixedsys was introduced at a later point
> and to this moment only one mt6795 based platform has a fhctl DT node
> present. Therefore the fhctl support in apmixedsys should be seen as
> optional and not cause an error when it is missing.
>
> Change the message's log level to warning. The warning level is chosen
> so that it will still alert the fact that fhctl support might be
> unintentionally missing, but without implying that this is necessarily
> an issue.
>
> Even if the FHCTL DT nodes are added to all current platforms moving
> forward, since those changes won't be backported, this ensures stable
> kernel releases won't have live with this error.
>
> Fixes: d7964de8a8ea ("clk: mediatek: Add new clock driver to handle FHCTL hardware")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2024-04-11 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 20:29 [PATCH] clk: mediatek: pllfh: Don't log error for missing fhctl node Nícolas F. R. A. Prado
2024-03-11 8:56 ` AngeloGioacchino Del Regno
2024-04-11 3:49 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6ecf39d6b4378731f3aa19350e0d5b7.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=edward-jw.yang@mediatek.com \
--cc=johnson.wang@mediatek.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox