From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43E22111; Thu, 19 Dec 2024 13:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734614191; cv=none; b=NTmVcBmJGOMku4twQEvlurrBpnm+ZFLTWWCAZoag/Lhpso6qtTFiok+v82kD4MG+XvroUElxqObRJBWOEzc5FxBn9qs10JdKDYRloIS0wlr21UFltkqd2A3f0ic5wl6FfUe3FOP9FdUj46J233h7V5M5rSc4SjcvzHbPZONjAZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734614191; c=relaxed/simple; bh=tbyc0WNAgDJHC4Vl5WmzrFRgY4K0gc/nEmc1D7ounhI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h83trE/69Rcbz2wooXzoaqmBAJESyd/3sHRYMWe4DreA1KzJmVrIS/Mc9oY0E2hsznN0EOJEfYnb32uUALxEY8ddB35BKHqrr+trlrCwLfkJ/mGx0BY+ZKWLtkdA7qXR+wpKOuazTWm2OXj63yL3+nJJJT6PiSNwpj4VnzIzLMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RJAOnQrT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RJAOnQrT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF4D2C4CECE; Thu, 19 Dec 2024 13:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734614190; bh=tbyc0WNAgDJHC4Vl5WmzrFRgY4K0gc/nEmc1D7ounhI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RJAOnQrTskuvFoT+XwL2yB5fXxRJtnO7s7gHLhtaEfa+IifQSaXc7IrcEfzPNwoTv F71JQqEtXKK1V55W2QV+rI9Q76KAmNBrQy+CWi7s1dOuNGVMnpJ89MCKSPRuNOOLwk 7HxbvfIyCAYEYyuF9LQkvr/IIr4zs2isKOz6zxhNAGzO3wcqBre4WflYZq7gILeNLF sPkgpt2570XrjEPik/vhC+yxyDYTuX9f2Sjh7q02YOa4TNtprp6WlWVnWD1kYaLmGH /MlGeBguVK6aWWm7OI/ympXqgPymt/haYFiEHcoIMn0bGLXhLDIRCfDkOjU4t2PMZt n8/Y5267maRQQ== Message-ID: Date: Thu, 19 Dec 2024 14:16:24 +0100 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-binding: clock: cs2600: Add support for the CS2600 To: Charles Keepax Cc: Paul Handrigan , mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, patches@opensource.cirrus.com References: <20241219024631.3145377-1-paulha@opensource.cirrus.com> <20241219024631.3145377-2-paulha@opensource.cirrus.com> <3glyuu4yg7wbykdsfm33m5evnn7fwg4dbplrkgzcceld3cgu2s@t3xjlhryt2y6> <3c09367c-808b-4414-bf6a-99e0bdaa3a27@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2024 13:59, Charles Keepax wrote: > On Thu, Dec 19, 2024 at 12:39:38PM +0100, Krzysztof Kozlowski wrote: >> On 19/12/2024 12:02, Charles Keepax wrote: >>> On Thu, Dec 19, 2024 at 09:51:00AM +0100, Krzysztof Kozlowski wrote: >>>> On Wed, Dec 18, 2024 at 08:46:30PM -0600, Paul Handrigan wrote: >>>>> +/* CS2600 Auxiliary Output */ >>>>> +#define CS2600_AUX_OUTPUT_FREQ_UNLOCK 0 >>>>> +#define CS2600_AUX_OUTPUT_PHASE_UNLOCK 1 >>>>> +#define CS2600_AUX_OUTPUT_NO_CLKIN 2 >>>> >>>> I still don't see why these three are supposed to be bindings. Drop >>>> them. >>> >>> In a binding one would presumably do: >>> >>> cirrus,aux-output-source = ; >>> >>> Apologies but I don't quite understand what you mean by the values >>> are not used in the binding? The driver reads the property and sets >> >> There is no user of these defines, so not a binding. >> >>> the pin to have the appropriate function. Admittedly one could drop >> >> It's not a proof that this is a binding. >> >>> the defines and then DTS would just have to do: >>> >>> cirrus,aux-output-source = <0>; >>> >>> But that feels a bit less helpful when reading the binding. >> >> Binding and being helpful are two different things. This to be the >> binding, it has to be used as a binding, so some translation layer >> between driver and DTS. It must have an user in DTS. I keep repeating >> this over and over... >> > > Apologies, but I not sure I totally follow this, and apologies if > you have already explained this are there some docs I can look > at? > > I think you are saying because these defines merely represent the > valid values for a device tree property and are not translated > into different values you can't put defines for them in the binding > header? > > So this would not be allowed: > > #define CS2600_AUX_OUTPUT_FREQ_UNLOCK 0 > > cirrus,aux-output-source = ; > > device_property_read_u32(dev, "cirrus,aux-output-source", &val); > regmap_write(regmap, CS2600_OUTPUT_CFG2, val); > > But this would be fine: > > #define CS2600_AUX_OUTPUT_FREQ_UNLOCK 1 > > cirrus,aux-output-source = ; > > device_property_read_u32(dev, "cirrus,aux-output-source", &val); > switch (val) { > case CS2600_AUX_OUTPUT_FREQ_UNLOCK: > regmap_write(regmap, CS2600_OUTPUT_CFG2, 0); > } > > And this would also be fine? > > cirrus,aux-output-source = <0>; > > device_property_read_u32(dev, "cirrus,aux-output-source", &val); > regmap_write(regmap, CS2600_OUTPUT_CFG2, val); > Yes. If you want to use in DTS user-readable values, then use string. Best regards, Krzysztof