From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD199320A3C for ; Wed, 26 Nov 2025 09:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764150152; cv=none; b=YthsLOpNjXq3ElsEOrrsuSCOGPVi5pxdQeRmT15Gh9C50GHdy9EVlJnQ4ipYNzgc+GWpJrcSr3+dhI1JxPlTE+VpESFUbOYjlTlCjQUuwN+BJT4HZxXuCqBskxtLCIyo0rfMSvMyC1FbH4WZNwU0oKXk3u6FuezwgYvVFLOYQ9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764150152; c=relaxed/simple; bh=YaOagR45wJEvzlU29fW0E8OsFsmOfRK5RTpmwuu7CRg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PyQvaMY1/9xSN5oHJ+vsGOASVVx6mAuAVSCSjzvnjLcIA4eTg4ErU5BJNCu5mgw8LFHVBOE9K6i8FPkTHgAN1nPWTXeb4fujkjtdiT0+U3+9EG+c//W4B27X+xg2d5mZ/qpZqrQ2NCIERNoHC1pupqCvu8e6TCAfHH4Qo22Wo3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=irfa7EDE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TyKnFnZp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="irfa7EDE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TyKnFnZp" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQ2FxRN3317325 for ; Wed, 26 Nov 2025 09:42:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A+vmaDrJ8wMl9VN3U7D8mZ8OuOHVZwepwJLL1teAkn4=; b=irfa7EDEGiRCiGud 5Vm5ucWvpTDGwUrARV+0YuhEhd/bXObwUtacPPvvZBJjsaJEo0MGutzKmv2OMvu8 HvWUjScfa8k+pJhfHzkp5eBTL353gpXLW6KOupp45QsC4d7OpFlAWS56Ru1vAeyH tgnahxlTZQleS/CLXPX7aCjMsC2QfQEIQ4ipSMdrgLTJIJLXBsLUHMoC+3FS3Uk2 SOBJUanpyAXaiZ1tZiVk3gNp70GR0E+itx7blnex2xVOBf6oZQTHm+WP79IJNfpj O9AtMfLUruAwg214PbOFGO/PBM7RNDs5VEphLXlWjlglcQAcCX+gHReG7XhYTVa0 NSv94g== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4and2qk2hw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Nov 2025 09:42:29 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b9321b9312so13640825b3a.1 for ; Wed, 26 Nov 2025 01:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764150147; x=1764754947; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A+vmaDrJ8wMl9VN3U7D8mZ8OuOHVZwepwJLL1teAkn4=; b=TyKnFnZpRQjB57M7X/5b8lv5QHk6LUKyo5+pVF0E0/GFlSvM/wKTS7Q/o+G62/SYvW 16LjNeYburpv2p7gUuQ9i3bMA90BfdJAKKOI+2e5QihAsoyvsqG1am0G5sbEkoXlfOW/ WPQTLeKg2FNo/OZuCYKlafcNxiPVBJ9B0F4GvFQXj77W+jF74jNKJo3Qowqg9NrrMsn1 4DI2MZDnmnqCGNUefCU7tQfrWfZ0T83TvkzKNmmpwH6pvd4CGiV+JcCL9wXyoYZXFiAP ppyLjKXiHnjBj3dAqMxX2uu5AmpLo4uCBy5G2NRpLBKFKsxnECQ5j1Zz0MpURE2MevCA pUcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764150147; x=1764754947; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A+vmaDrJ8wMl9VN3U7D8mZ8OuOHVZwepwJLL1teAkn4=; b=WBCCmc803/UFy8H/OD2UMKUps9ancd0KfmqJyyDHBPukMVoE9/X0XURfODdwRWae/l jTH7PPHGBIl9NwHATX3T/WyvQV/L6U5QexJSWH2HrSmAcDDBpxUK12zk6ijiaVRTgFBz Wi8PzTWcDH54oSQgXi5I0Q2HZtS8XNJPkg3a+379gc09bq19meslt/rYgdyOlwZwHFFr PHJhTE7Zr46kKtVR143xnumAhR6Ez8yRa0+pSsg2FRgdowV5DO3VOYyyzcXWrxL6YLqI 9CuLqymSF7eWrbMAV8hYFhgJrl51iKgMr+EETDMY5wGZMZPr8NtBeDfgoO+WedEgLkY8 40IQ== X-Forwarded-Encrypted: i=1; AJvYcCU+DB+dYTeAgi4nmGexTtNLpuNnj4QGOb6ygJSjgzHyTggUW0je7ParFCJ3qceuKZNk1Z/sT+ULWzw=@vger.kernel.org X-Gm-Message-State: AOJu0YxTKbyn+YPhwNx//O0CQWbFlq2KfbvgTp77PGebJfEmMewnGutq uA93XdHJ0TkMsLW0FXZjmKecKphg0ysPj8LoCZYGzoHkajQYR700O7/4/d334LKXI2kQlWp4Uii GlEddzvP5hLtt9yNNqUkdE5FZpCIub7cgH+Zk1xzhDOD5EvwcCIhZADKnxskIErs= X-Gm-Gg: ASbGnctoUn0/EecyInVb94HCcaEI+gshze7N8YPXFjsHhVj2B0rNMa8U0ZphULCkZlf z4Qr84wkDs0VRYrSD/QbaKlbj1z5bvch5Gy2M37H/ud8MPa4kCgnudqMVxQPKErqZWd1WAh8Kfl 6B8YyNQiBHSGpVP4rNBnnOAXiDbfGbJ9Jr/ISWJkhLIjY0etBvNV5UcTXHLfdSQYt0AeBx3uPNm mXvUQ4QqZMIod4c1R/oPwyK8nD9IB8fG68BHPfjVJGpk3x7U32aQaY6FeluwA78qENY5Z2MPLF3 C53lc+7Gp3lx4Q+YfQuISTgyaj6Fbb4UjGaw+iC11FPESzDrjtRnNM6u0mmHOUEe+VXzJUt7wxj s13mXUw8Lvh4G2eYngaKxxYuFXltDMKpnCkgQ5g== X-Received: by 2002:a05:6a00:2e82:b0:7aa:9723:3217 with SMTP id d2e1a72fcca58-7c58e40f6dcmr17360457b3a.25.1764150147510; Wed, 26 Nov 2025 01:42:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGr5zUDSSGpqPXRi6ejp/L1iEUkIdgvCyK4NLiuUnUALMP9mDPHoJdhB8kUj1RkbTTmBrVpAA== X-Received: by 2002:a05:6a00:2e82:b0:7aa:9723:3217 with SMTP id d2e1a72fcca58-7c58e40f6dcmr17360420b3a.25.1764150146969; Wed, 26 Nov 2025 01:42:26 -0800 (PST) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3ed37ab3fsm21135122b3a.22.2025.11.26.01.42.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Nov 2025 01:42:26 -0800 (PST) Message-ID: Date: Wed, 26 Nov 2025 15:12:19 +0530 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] clk: qcom: gcc-sm8450: Update the SDCC RCGs to use shared_floor_ops To: Jagadeesh Kona , Bjorn Andersson , Michael Turquette , Stephen Boyd , Vinod Koul , Konrad Dybcio , Dmitry Baryshkov , Taniya Das , Melody Olvera , Ajit Pandey , Imran Shaik , Luca Weiss Cc: Ajit Pandey , Imran Shaik , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251126-sdcc_shared_floor_ops-v1-0-9038430dfed4@oss.qualcomm.com> <20251126-sdcc_shared_floor_ops-v1-1-9038430dfed4@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <20251126-sdcc_shared_floor_ops-v1-1-9038430dfed4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDA3OSBTYWx0ZWRfXx6xMxKHNIlQO k6suJFNwx+C9I0LtCXEut8TI0gUPqg/oNYXnQamKHsHGRbJ3MaEt4lJSekO2g8I4De5dWMUHzuU va75tu4nstPjUn07GYcQc3d8NrOodjD91b5E/5L4Pqn7C9tizZylzCMQjM63HV8Mq55WtLsruJD Kh1wcRywBZNAvQAtcMnI1izVYdd4J6AHiX0zSOVj6oAgLSjntrOuy+sqknumkCHlnuyZTkAYzvL F7OdB12xP9o69vxzBNziG0zuD797LoQhVoEh/56wpfCTW2/QtJj8Gc2y0QvP/yNVjJmXWMupgwC 1v9HRUBQy6vZB39pl8ApwMI+11lfzSixEwYLjajQcF/6YV5TVdaNbqeBwbVxKoDktPf4kVSr6Jo i73tV+o6pAkDCFmKMj5T1bCtdea0Ew== X-Authority-Analysis: v=2.4 cv=dZyNHHXe c=1 sm=1 tr=0 ts=6926cb85 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7HKD0IT6kqf3lY0ElOQA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: mvPhAAFAtz8KjBYG3smLVyn3uFbWosPa X-Proofpoint-GUID: mvPhAAFAtz8KjBYG3smLVyn3uFbWosPa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 clxscore=1015 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260079 On 11/26/2025 9:45 AM, Jagadeesh Kona wrote: > Use shared_floor_ops for the SDCC RCGs so the RCG is safely parked > during disable and the new parent configuration is programmed in > hardware only when the new parent is enabled, avoiding cases where > the RCG configuration fails to update. > > Fixes: a27ac3806b0a ("clk: qcom: gcc-sm8450: Use floor ops for SDCC RCGs") > Signed-off-by: Jagadeesh Kona > --- > drivers/clk/qcom/gcc-sm8450.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c > index 65d7d52bce034335707014797fe9002429212a14..b18bb34889ab28fba13cbf2ca8cf83101e4e0484 100644 > --- a/drivers/clk/qcom/gcc-sm8450.c > +++ b/drivers/clk/qcom/gcc-sm8450.c > @@ -1034,7 +1034,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > .parent_data = gcc_parent_data_7, > .num_parents = ARRAY_SIZE(gcc_parent_data_7), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > @@ -1057,7 +1057,7 @@ static struct clk_rcg2 gcc_sdcc4_apps_clk_src = { > .parent_data = gcc_parent_data_0, > .num_parents = ARRAY_SIZE(gcc_parent_data_0), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > Reviewed-by: Taniya Das -- Thanks, Taniya Das